From: Vidya Sagar <vidyas@nvidia.com>
To: <bhelgaas@google.com>, <rdunlap@infradead.org>,
<ilpo.jarvinen@linux.intel.com>, <tglx@linutronix.de>,
<jiang.liu@linux.intel.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<treding@nvidia.com>, <jonathanh@nvidia.com>,
<sdonthineni@nvidia.com>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>, <vidyas@nvidia.com>,
<sagar.tv@gmail.com>
Subject: [PATCH V3] PCI/MSI: Fix MSI hwirq truncation
Date: Thu, 11 Jan 2024 10:58:14 +0530 [thread overview]
Message-ID: <20240111052814.713016-1-vidyas@nvidia.com> (raw)
In-Reply-To: <20240108120522.1368240-1-vidyas@nvidia.com>
While calculating the hwirq number for an MSI interrupt, the higher
bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
number gets truncated because of the shifted value casting to return
type of pci_domain_nr() which is 'int'. This for example is resulting
in same hwirq number for devices 0019:00:00.0 and 0039:00:00.0.
So, cast the PCI domain number to 'irq_hw_number_t' before left shifting
it to calculate hwirq number.
Fixes: 3878eaefb89a ("PCI/MSI: Enhance core to support hierarchy irqdomain")
Tested-By: Shanker Donthineni <sdonthineni@nvidia.com>
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
V3:
* Addressed review comments from Thomas Gleixner
* Added Tested-By: Shanker Donthineni <sdonthineni@nvidia.com>
V2:
* Added Fixes tag
drivers/pci/msi/irqdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
index c8be056c248d..cfd84a899c82 100644
--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -61,7 +61,7 @@ static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
return (irq_hw_number_t)desc->msi_index |
pci_dev_id(dev) << 11 |
- (pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
+ ((irq_hw_number_t)(pci_domain_nr(dev->bus) & 0xFFFFFFFF)) << 27;
}
static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
--
2.25.1
next prev parent reply other threads:[~2024-01-11 5:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 13:43 [PATCH V1] PCI/MSI: Fix MSI hwirq truncation Vidya Sagar
2024-01-05 17:02 ` Kuppuswamy Sathyanarayanan
2024-01-08 11:58 ` Vidya Sagar
2024-01-08 12:05 ` [PATCH V2] " Vidya Sagar
2024-01-08 14:09 ` Shanker Donthineni
2024-01-10 10:12 ` Thomas Gleixner
2024-01-10 18:04 ` Vidya Sagar
2024-01-11 5:28 ` Vidya Sagar [this message]
2024-01-12 15:53 ` [PATCH V3] " Thomas Gleixner
2024-01-12 17:33 ` Vidya Sagar
2024-01-15 10:01 ` Thomas Gleixner
2024-01-15 13:50 ` Vidya Sagar
2024-01-15 13:56 ` [PATCH V4] " Vidya Sagar
2024-01-23 16:01 ` Vidya Sagar
2024-01-31 3:15 ` Vidya Sagar
2024-02-07 6:59 ` Vidya Sagar
2024-02-07 10:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111052814.713016-1-vidyas@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiang.liu@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=sagar.tv@gmail.com \
--cc=sdonthineni@nvidia.com \
--cc=tglx@linutronix.de \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox