From: Lukas Wunner <lukas@wunner.de>
To: Alexey Kardashevskiy <aik@amd.com>
Cc: linux-pci@vger.kernel.org, "Martin Mareš" <mj@ucw.cz>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH pciutils v2 1/2] ls-ecaps: Add decode support for IDE Extended Capability
Date: Mon, 26 Feb 2024 20:24:44 +0100 [thread overview]
Message-ID: <20240226192444.GA22489@wunner.de> (raw)
In-Reply-To: <20240226060135.3252162-2-aik@amd.com>
On Mon, Feb 26, 2024 at 05:01:34PM +1100, Alexey Kardashevskiy wrote:
> IDE (Integrity & Data Encryption) Extended Capability defined in [1]
> implements control of the PCI link encryption. The verbose level > 2 prints
> offsets of the fields to make running setpci easier.
>
> The example output is:
>
> Capabilities: [830 v1] Integrity & Data Encryption
> IDECap: Lnk=0 Sel=1 FlowThru- PartHdr- Aggr- PCPC- IDE_KM+ Alg='AES-GCM-256-96b' TCs=8 TeeLim+
Hm, I'm wondering if the Supported Algorithms should be listed on a
line by themselves, each enumerated with a '+' or '-' indicator?
Maybe that's easier to parse?
In general, I'd prefer it if the output was linewrapped at 80 chars,
(i.e. begin a new line and indent as appropriate).
Thanks,
Lukas
next prev parent reply other threads:[~2024-02-26 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 6:01 [PATCH pciutils v2 0/2] lspci: Adding TDISP, IDE Alexey Kardashevskiy
2024-02-26 6:01 ` [PATCH pciutils v2 1/2] ls-ecaps: Add decode support for IDE Extended Capability Alexey Kardashevskiy
2024-02-26 19:24 ` Lukas Wunner [this message]
2024-02-27 2:27 ` Alexey Kardashevskiy
2024-02-26 6:01 ` [PATCH pciutils v2 2/2] lspci: Add TEE-IO extended capability bit Alexey Kardashevskiy
2024-02-26 9:10 ` [PATCH pciutils v2 0/2] lspci: Adding TDISP, IDE Martin Mareš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226192444.GA22489@wunner.de \
--to=lukas@wunner.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=aik@amd.com \
--cc=linux-pci@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox