Re: [PATCH pciutils v2 1/2] ls-ecaps: Add decode support for IDE Extended Capability

[Alexey Kardashevskiy <aik@amd.com>]

On 27/2/24 06:24, Lukas Wunner wrote:
> On Mon, Feb 26, 2024 at 05:01:34PM +1100, Alexey Kardashevskiy wrote:
>> IDE (Integrity & Data Encryption) Extended Capability defined in [1]
>> implements control of the PCI link encryption. The verbose level > 2 prints
>> offsets of the fields to make running setpci easier.
>>
>> The example output is:
>>
>> Capabilities: [830 v1] Integrity & Data Encryption
>> 	IDECap: Lnk=0 Sel=1 FlowThru- PartHdr- Aggr- PCPC- IDE_KM+ Alg='AES-GCM-256-96b' TCs=8 TeeLim+
> 
> Hm, I'm wondering if the Supported Algorithms should be listed on a
> line by themselves, each enumerated with a '+' or '-' indicator?
> Maybe that's easier to parse?

I'd leave this for later when PCIe defines another one (or more). And I 
was hoping someone suggested better (==shorter) acronym for the 
algorithm, may be just call it "AES256"?

> In general, I'd prefer it if the output was linewrapped at 80 chars,
> (i.e. begin a new line and indent as appropriate).

Well, too late, there are examples in "tests" 114 chars long. It is 2024 
after all, everyone got a big screen, even Linus :) Thanks,

> 
> Thanks,
> 
> Lukas

-- 
Alexey