From: Frank Li <Frank.Li@nxp.com>
To: cassel@kernel.org
Cc: Frank.li@nxp.com, arnd@arndb.de, gregkh@linuxfoundation.org,
kishon@kernel.org, kw@linux.com, linux-pci@vger.kernel.org,
manivannan.sadhasivam@linaro.org
Subject: [PATCH 1/1] misc: pci_endpoint_test: Refactor dma_set_mask_and_coherent() logic
Date: Thu, 28 Mar 2024 12:06:32 -0400 [thread overview]
Message-ID: <20240328160632.848414-1-Frank.Li@nxp.com> (raw)
dma_set_mask_and_coherent() will never return failure when mask >= 32bit.
So needn't fall back to set dma_set_mask_and_coherent(32).
Even if dma_set_mask_and_coherent(48) failure,
dma_set_mask_and_coherent(32) will be failure according to the same reason.
The function dma_set_mask_and_coherent() defines the device DMA access
address width. If it's capable of accessing 48 bits, it inherently supports
32-bit space as well.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Notes:
Ref: https://lore.kernel.org/linux-pci/20240328154827.809286-1-Frank.Li@nxp.com/T/#u
for document change patch. DMA document sample code is miss leading.
drivers/misc/pci_endpoint_test.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index c38a6083f0a73..56ac6969a8f59 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -824,11 +824,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
init_completion(&test->irq_raised);
mutex_init(&test->mutex);
- if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(48)) != 0) &&
- dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) {
- dev_err(dev, "Cannot set DMA mask\n");
- return -EINVAL;
- }
+ dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(48));
err = pci_enable_device(pdev);
if (err) {
--
2.34.1
next reply other threads:[~2024-03-28 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 16:06 Frank Li [this message]
2024-04-02 6:20 ` [PATCH 1/1] misc: pci_endpoint_test: Refactor dma_set_mask_and_coherent() logic Manivannan Sadhasivam
2024-04-02 8:34 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328160632.848414-1-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=arnd@arndb.de \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox