From: Niklas Cassel <cassel@kernel.org>
To: kishon@kernel.org
Cc: arnd@arndb.de, gregkh@linuxfoundation.org, kishon@kernel.org,
kw@linux.com, linux-pci@vger.kernel.org,
manivannan.sadhasivam@linaro.org, Frank.li@nxp.com
Subject: Re: [PATCH 1/1] misc: pci_endpoint_test: Refactor dma_set_mask_and_coherent() logic
Date: Tue, 2 Apr 2024 10:34:29 +0200 [thread overview]
Message-ID: <ZgvDFR0HDopzy9zD@ryzen> (raw)
In-Reply-To: <20240328160632.848414-1-Frank.Li@nxp.com>
On Thu, Mar 28, 2024 at 12:06:32PM -0400, Frank Li wrote:
> dma_set_mask_and_coherent() will never return failure when mask >= 32bit.
> So needn't fall back to set dma_set_mask_and_coherent(32).
>
> Even if dma_set_mask_and_coherent(48) failure,
> dma_set_mask_and_coherent(32) will be failure according to the same reason.
>
> The function dma_set_mask_and_coherent() defines the device DMA access
> address width. If it's capable of accessing 48 bits, it inherently supports
> 32-bit space as well.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Kishon,
do you remember why you set the DMA mask to 48-bits in the first place?
It seems a bit random.
Kind regards,
Niklas
prev parent reply other threads:[~2024-04-02 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 16:06 [PATCH 1/1] misc: pci_endpoint_test: Refactor dma_set_mask_and_coherent() logic Frank Li
2024-04-02 6:20 ` Manivannan Sadhasivam
2024-04-02 8:34 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgvDFR0HDopzy9zD@ryzen \
--to=cassel@kernel.org \
--cc=Frank.li@nxp.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox