* [PATCH 1/2] PCI/ERR: Cleanup misleading indentation inside if conditions @ 2024-04-29 9:47 Ilpo Järvinen 2024-04-29 9:47 ` [PATCH 2/2] PCI: Cleanup accessor macros formatting Ilpo Järvinen 0 siblings, 1 reply; 3+ messages in thread From: Ilpo Järvinen @ 2024-04-29 9:47 UTC (permalink / raw) To: Mahesh J Salgaonkar, Oliver O'Halloran, Bjorn Helgaas, linuxppc-dev, linux-pci, linux-kernel Cc: Ilpo Järvinen A few if conditions align misleadingly with the following code block. The checks are really cascading NULL checks that fit into 80 chars so remove newlines in between and realign to the if condition indent. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/pci/pcie/err.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index 705893b5f7b0..31090770fffc 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -116,9 +116,7 @@ static int report_mmio_enabled(struct pci_dev *dev, void *data) device_lock(&dev->dev); pdrv = dev->driver; - if (!pdrv || - !pdrv->err_handler || - !pdrv->err_handler->mmio_enabled) + if (!pdrv || !pdrv->err_handler || !pdrv->err_handler->mmio_enabled) goto out; err_handler = pdrv->err_handler; @@ -137,9 +135,7 @@ static int report_slot_reset(struct pci_dev *dev, void *data) device_lock(&dev->dev); pdrv = dev->driver; - if (!pdrv || - !pdrv->err_handler || - !pdrv->err_handler->slot_reset) + if (!pdrv || !pdrv->err_handler || !pdrv->err_handler->slot_reset) goto out; err_handler = pdrv->err_handler; @@ -158,9 +154,7 @@ static int report_resume(struct pci_dev *dev, void *data) device_lock(&dev->dev); pdrv = dev->driver; if (!pci_dev_set_io_state(dev, pci_channel_io_normal) || - !pdrv || - !pdrv->err_handler || - !pdrv->err_handler->resume) + !pdrv || !pdrv->err_handler || !pdrv->err_handler->resume) goto out; err_handler = pdrv->err_handler; -- 2.39.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] PCI: Cleanup accessor macros formatting 2024-04-29 9:47 [PATCH 1/2] PCI/ERR: Cleanup misleading indentation inside if conditions Ilpo Järvinen @ 2024-04-29 9:47 ` Ilpo Järvinen 2024-04-29 15:49 ` Bjorn Helgaas 0 siblings, 1 reply; 3+ messages in thread From: Ilpo Järvinen @ 2024-04-29 9:47 UTC (permalink / raw) To: Bjorn Helgaas, linux-pci, linux-kernel; +Cc: Ilpo Järvinen Cleanup formatting of PCI accessor macros: - Put return statements on own line - Add a few empty lines for better readability - Align macro continuation backslashes - Correct function call argument indentation level - Reorder variable declarations to reverse xmas tree Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/pci/access.c | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 6449056b57dd..4962a841fa35 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -36,10 +36,13 @@ DEFINE_RAW_SPINLOCK(pci_lock); int noinline pci_bus_read_config_##size \ (struct pci_bus *bus, unsigned int devfn, int pos, type *value) \ { \ - int res; \ unsigned long flags; \ u32 data = 0; \ - if (PCI_##size##_BAD) return PCIBIOS_BAD_REGISTER_NUMBER; \ + int res; \ + \ + if (PCI_##size##_BAD) \ + return PCIBIOS_BAD_REGISTER_NUMBER; \ + \ pci_lock_config(flags); \ res = bus->ops->read(bus, devfn, pos, len, &data); \ if (res) \ @@ -47,6 +50,7 @@ int noinline pci_bus_read_config_##size \ else \ *value = (type)data; \ pci_unlock_config(flags); \ + \ return res; \ } @@ -54,12 +58,16 @@ int noinline pci_bus_read_config_##size \ int noinline pci_bus_write_config_##size \ (struct pci_bus *bus, unsigned int devfn, int pos, type value) \ { \ - int res; \ unsigned long flags; \ - if (PCI_##size##_BAD) return PCIBIOS_BAD_REGISTER_NUMBER; \ + int res; \ + \ + if (PCI_##size##_BAD) \ + return PCIBIOS_BAD_REGISTER_NUMBER; \ + \ pci_lock_config(flags); \ res = bus->ops->write(bus, devfn, pos, len, value); \ pci_unlock_config(flags); \ + \ return res; \ } @@ -216,24 +224,27 @@ static noinline void pci_wait_cfg(struct pci_dev *dev) } /* Returns 0 on success, negative values indicate error. */ -#define PCI_USER_READ_CONFIG(size, type) \ +#define PCI_USER_READ_CONFIG(size, type) \ int pci_user_read_config_##size \ (struct pci_dev *dev, int pos, type *val) \ { \ int ret = PCIBIOS_SUCCESSFUL; \ u32 data = -1; \ + \ if (PCI_##size##_BAD) \ return -EINVAL; \ - raw_spin_lock_irq(&pci_lock); \ + \ + raw_spin_lock_irq(&pci_lock); \ if (unlikely(dev->block_cfg_access)) \ pci_wait_cfg(dev); \ ret = dev->bus->ops->read(dev->bus, dev->devfn, \ - pos, sizeof(type), &data); \ - raw_spin_unlock_irq(&pci_lock); \ + pos, sizeof(type), &data); \ + raw_spin_unlock_irq(&pci_lock); \ if (ret) \ PCI_SET_ERROR_RESPONSE(val); \ else \ *val = (type)data; \ + \ return pcibios_err_to_errno(ret); \ } \ EXPORT_SYMBOL_GPL(pci_user_read_config_##size); @@ -244,14 +255,17 @@ int pci_user_write_config_##size \ (struct pci_dev *dev, int pos, type val) \ { \ int ret = PCIBIOS_SUCCESSFUL; \ + \ if (PCI_##size##_BAD) \ return -EINVAL; \ - raw_spin_lock_irq(&pci_lock); \ + \ + raw_spin_lock_irq(&pci_lock); \ if (unlikely(dev->block_cfg_access)) \ pci_wait_cfg(dev); \ ret = dev->bus->ops->write(dev->bus, dev->devfn, \ - pos, sizeof(type), val); \ - raw_spin_unlock_irq(&pci_lock); \ + pos, sizeof(type), val); \ + raw_spin_unlock_irq(&pci_lock); \ + \ return pcibios_err_to_errno(ret); \ } \ EXPORT_SYMBOL_GPL(pci_user_write_config_##size); -- 2.39.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] PCI: Cleanup accessor macros formatting 2024-04-29 9:47 ` [PATCH 2/2] PCI: Cleanup accessor macros formatting Ilpo Järvinen @ 2024-04-29 15:49 ` Bjorn Helgaas 0 siblings, 0 replies; 3+ messages in thread From: Bjorn Helgaas @ 2024-04-29 15:49 UTC (permalink / raw) To: Ilpo Järvinen; +Cc: Bjorn Helgaas, linux-pci, linux-kernel On Mon, Apr 29, 2024 at 12:47:07PM +0300, Ilpo Järvinen wrote: > Cleanup formatting of PCI accessor macros: > > - Put return statements on own line > - Add a few empty lines for better readability > - Align macro continuation backslashes > - Correct function call argument indentation level > - Reorder variable declarations to reverse xmas tree > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Both applied to pci/misc for v6.10, thanks! I tweaked the PCI_USER_READ_CONFIG variable declaration from the existing reverse xmas tree to order of use because xmas tree orders look nice but carry no useful information. In the cases you updated, reverse xmas tree and order of use happen to be the same. Also dropped "ret" initialization in PCI_USER_READ_CONFIG and PCI_USER_WRITE_CONFIG since it's always set before being used anyway. > --- > drivers/pci/access.c | 36 +++++++++++++++++++++++++----------- > 1 file changed, 25 insertions(+), 11 deletions(-) > > diff --git a/drivers/pci/access.c b/drivers/pci/access.c > index 6449056b57dd..4962a841fa35 100644 > --- a/drivers/pci/access.c > +++ b/drivers/pci/access.c > @@ -36,10 +36,13 @@ DEFINE_RAW_SPINLOCK(pci_lock); > int noinline pci_bus_read_config_##size \ > (struct pci_bus *bus, unsigned int devfn, int pos, type *value) \ > { \ > - int res; \ > unsigned long flags; \ > u32 data = 0; \ > - if (PCI_##size##_BAD) return PCIBIOS_BAD_REGISTER_NUMBER; \ > + int res; \ > + \ > + if (PCI_##size##_BAD) \ > + return PCIBIOS_BAD_REGISTER_NUMBER; \ > + \ > pci_lock_config(flags); \ > res = bus->ops->read(bus, devfn, pos, len, &data); \ > if (res) \ > @@ -47,6 +50,7 @@ int noinline pci_bus_read_config_##size \ > else \ > *value = (type)data; \ > pci_unlock_config(flags); \ > + \ > return res; \ > } > > @@ -54,12 +58,16 @@ int noinline pci_bus_read_config_##size \ > int noinline pci_bus_write_config_##size \ > (struct pci_bus *bus, unsigned int devfn, int pos, type value) \ > { \ > - int res; \ > unsigned long flags; \ > - if (PCI_##size##_BAD) return PCIBIOS_BAD_REGISTER_NUMBER; \ > + int res; \ > + \ > + if (PCI_##size##_BAD) \ > + return PCIBIOS_BAD_REGISTER_NUMBER; \ > + \ > pci_lock_config(flags); \ > res = bus->ops->write(bus, devfn, pos, len, value); \ > pci_unlock_config(flags); \ > + \ > return res; \ > } > > @@ -216,24 +224,27 @@ static noinline void pci_wait_cfg(struct pci_dev *dev) > } > > /* Returns 0 on success, negative values indicate error. */ > -#define PCI_USER_READ_CONFIG(size, type) \ > +#define PCI_USER_READ_CONFIG(size, type) \ > int pci_user_read_config_##size \ > (struct pci_dev *dev, int pos, type *val) \ > { \ > int ret = PCIBIOS_SUCCESSFUL; \ > u32 data = -1; \ > + \ > if (PCI_##size##_BAD) \ > return -EINVAL; \ > - raw_spin_lock_irq(&pci_lock); \ > + \ > + raw_spin_lock_irq(&pci_lock); \ > if (unlikely(dev->block_cfg_access)) \ > pci_wait_cfg(dev); \ > ret = dev->bus->ops->read(dev->bus, dev->devfn, \ > - pos, sizeof(type), &data); \ > - raw_spin_unlock_irq(&pci_lock); \ > + pos, sizeof(type), &data); \ > + raw_spin_unlock_irq(&pci_lock); \ > if (ret) \ > PCI_SET_ERROR_RESPONSE(val); \ > else \ > *val = (type)data; \ > + \ > return pcibios_err_to_errno(ret); \ > } \ > EXPORT_SYMBOL_GPL(pci_user_read_config_##size); > @@ -244,14 +255,17 @@ int pci_user_write_config_##size \ > (struct pci_dev *dev, int pos, type val) \ > { \ > int ret = PCIBIOS_SUCCESSFUL; \ > + \ > if (PCI_##size##_BAD) \ > return -EINVAL; \ > - raw_spin_lock_irq(&pci_lock); \ > + \ > + raw_spin_lock_irq(&pci_lock); \ > if (unlikely(dev->block_cfg_access)) \ > pci_wait_cfg(dev); \ > ret = dev->bus->ops->write(dev->bus, dev->devfn, \ > - pos, sizeof(type), val); \ > - raw_spin_unlock_irq(&pci_lock); \ > + pos, sizeof(type), val); \ > + raw_spin_unlock_irq(&pci_lock); \ > + \ > return pcibios_err_to_errno(ret); \ > } \ > EXPORT_SYMBOL_GPL(pci_user_write_config_##size); > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-29 15:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-04-29 9:47 [PATCH 1/2] PCI/ERR: Cleanup misleading indentation inside if conditions Ilpo Järvinen 2024-04-29 9:47 ` [PATCH 2/2] PCI: Cleanup accessor macros formatting Ilpo Järvinen 2024-04-29 15:49 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox