* [PATCH] x86: Code cleanup for ehci_hdr
@ 2024-01-25 3:06 Kunwu Chan
2024-05-03 22:12 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Kunwu Chan @ 2024-01-25 3:06 UTC (permalink / raw)
To: bhelgaas, tglx, mingo, bp, dave.hansen, x86, hpa
Cc: linux-pci, linux-kernel, Kunwu Chan
This part was commented from commit 3ef0e1f8cad0
("x86: olpc: add One Laptop Per Child architecture support")
in about 16 years before.
If there are no plans to enable this part code in the future,
we can remove this dead code.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
arch/x86/pci/olpc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/pci/olpc.c b/arch/x86/pci/olpc.c
index f3aab76e357a..4b18c6404363 100644
--- a/arch/x86/pci/olpc.c
+++ b/arch/x86/pci/olpc.c
@@ -154,9 +154,6 @@ static const uint32_t ehci_hdr[] = { /* dev f function 4 - devfn = 7d */
0x0, 0x40, 0x0, 0x40a, /* CapPtr INT-D, IRQA */
0xc8020001, 0x0, 0x0, 0x0, /* Capabilities - 40 is R/O, 44 is
mask 8103 (power control) */
-#if 0
- 0x1, 0x40080000, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
-#endif
0x01000001, 0x0, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
0x2020, 0x0, 0x0, 0x0, /* (EHCI page 8) 60 SBRN (R/O),
61 FLADJ (R/W), PORTWAKECAP */
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86: Code cleanup for ehci_hdr
2024-01-25 3:06 [PATCH] x86: Code cleanup for ehci_hdr Kunwu Chan
@ 2024-05-03 22:12 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2024-05-03 22:12 UTC (permalink / raw)
To: Kunwu Chan
Cc: bhelgaas, tglx, mingo, bp, dave.hansen, x86, hpa, linux-pci,
linux-kernel, Andres Salomon
[+cc Andres, author of 3ef0e1f8cad0]
On Thu, Jan 25, 2024 at 11:06:23AM +0800, Kunwu Chan wrote:
> This part was commented from commit 3ef0e1f8cad0
> ("x86: olpc: add One Laptop Per Child architecture support")
> in about 16 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Applied to pci/misc for v6.10, thanks.
> ---
> arch/x86/pci/olpc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/pci/olpc.c b/arch/x86/pci/olpc.c
> index f3aab76e357a..4b18c6404363 100644
> --- a/arch/x86/pci/olpc.c
> +++ b/arch/x86/pci/olpc.c
> @@ -154,9 +154,6 @@ static const uint32_t ehci_hdr[] = { /* dev f function 4 - devfn = 7d */
> 0x0, 0x40, 0x0, 0x40a, /* CapPtr INT-D, IRQA */
> 0xc8020001, 0x0, 0x0, 0x0, /* Capabilities - 40 is R/O, 44 is
> mask 8103 (power control) */
> -#if 0
> - 0x1, 0x40080000, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
> -#endif
> 0x01000001, 0x0, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
> 0x2020, 0x0, 0x0, 0x0, /* (EHCI page 8) 60 SBRN (R/O),
> 61 FLADJ (R/W), PORTWAKECAP */
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-03 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-25 3:06 [PATCH] x86: Code cleanup for ehci_hdr Kunwu Chan
2024-05-03 22:12 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox