Linux PCI subsystem development
 help / color / mirror / Atom feed
* [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'
@ 2024-05-07 23:23 linux
  2024-05-08  7:55 ` Ilpo Järvinen
  0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2024-05-07 23:23 UTC (permalink / raw)
  To: bhelgaas, ilpo.jarvinen, dave.hansen
  Cc: x86, linux-pci, linux-kernel, Dr. David Alan Gilbert

From: "Dr. David Alan Gilbert" <linux@treblig.org>

struct 'sim_reg_op' doesn't look like it was ever used.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 arch/x86/pci/ce4100.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
index 87313701f069e..f5dbd25651e0f 100644
--- a/arch/x86/pci/ce4100.c
+++ b/arch/x86/pci/ce4100.c
@@ -35,12 +35,6 @@ struct sim_dev_reg {
 	struct sim_reg sim_reg;
 };
 
-struct sim_reg_op {
-	void (*init)(struct sim_dev_reg *reg);
-	void (*read)(struct sim_dev_reg *reg, u32 value);
-	void (*write)(struct sim_dev_reg *reg, u32 value);
-};
-
 #define MB (1024 * 1024)
 #define KB (1024)
 #define SIZE_TO_MASK(size) (~(size - 1))
-- 
2.45.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'
  2024-05-07 23:23 [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op' linux
@ 2024-05-08  7:55 ` Ilpo Järvinen
  0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2024-05-08  7:55 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: bhelgaas, dave.hansen, x86, linux-pci, LKML

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

On Wed, 8 May 2024, linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> struct 'sim_reg_op' doesn't look like it was ever used.
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  arch/x86/pci/ce4100.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
>  	struct sim_reg sim_reg;
>  };
>  
> -struct sim_reg_op {
> -	void (*init)(struct sim_dev_reg *reg);
> -	void (*read)(struct sim_dev_reg *reg, u32 value);
> -	void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -

Thanks.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-08  7:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-07 23:23 [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op' linux
2024-05-08  7:55 ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox