Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Kalle Valo <kvalo@kernel.org> writes:

> Kalle Valo <kvalo@kernel.org> writes:
>
>> Yesterday I run our ath11k regression tests with v6.10-rc1 and our
>> simple ath11k module reload stress started failing reliably with various
>> KASAN errors. The test removes and inserts ath11k and other wireless
>> modules in a loop. Usually I run it at least 100 times, some times even
>> more, and no issues until yesterday.
>>
>> I have verified that the last wireless-next pull request (tag
>> wireless-next-2024-05-08) works without issues and v6.10-rc1 fails
>> always, usually within 50 module reload loops. From this I'm _guessing_
>> that we have a regression outside wireless, most probably introduced
>> between v6.9 and v6.10-rc1. But of course I cannot be sure of anything
>> yet.
>>
>> I see different KASAN warnings and lockdep seems to be always visible in
>> the stack traces. I think I can reproduce the issue within 15 minutes or
>> so. Before I start bisecting has anyone else seen anything similar? Or
>> any suggestions how to debug this further?
>>
>> I have included some crash logs below, they are retrieved using
>> netconsole. Here's a summary of the errors:
>>
>> [ 159.970765] KASAN: maybe wild-memory-access in range
>> [0xbbbbbbbbbbbbbbb8-0xbbbbbbbbbbbbbbbf]
>> [  700.017632] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0
>> [  224.695821] BUG: KASAN: slab-out-of-bounds in lockdep_register_key+0x755/0x8f0
>> [  259.666542] BUG: KASAN: slab-use-after-free in lockdep_register_key+0x755/0x8f0
>
> I did a bisect and got this:
>
> cf29111d3e4a9ebe1cbe2b431274718506d69f10 is the first bad commit
> commit cf29111d3e4a9ebe1cbe2b431274718506d69f10
> Merge: ed11a28cb709 e6f7d27df5d2
> Author: Bjorn Helgaas <bhelgaas@google.com>
> Date:   Thu May 16 18:14:11 2024 -0500
>
>     Merge branch 'pci/of'
>     
>     - Check for kcalloc() failure and handle it gracefully (Duoming Zhou)
>     
>     * pci/of:
>       PCI: of_property: Return error for int_map allocation failure
>
>  drivers/pci/of_property.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> But that doesn't make any sense to me, I don't even have
> CONFIG_PCI_DYNAMIC_OF_NODES enabled in my .config. I guess I did a
> mistake during bisect, I'm now testing the parents (e6f7d27df5d2 and
> ed11a28cb709) and trying to pinpoint where I did it wrong.

I found my mistake and was able to finish the bisect. This seems to be
the commit causing my problems:

# first bad commit: [7e89efc6e9e402839643cb297bab14055c547f07] PCI: Lock upstream bridge for pci_reset_function()

I verified by reverting that commit on top of v6.10-rc1 and I have not
seen any crashes so far, normally I would have seen it by now. But I
will continue testing the revert just to be sure.

Adding people and lists involved with that commit. Here is my original
report:

https://lore.kernel.org/all/87v82y6wvi.fsf@kernel.org/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Linux regression tracking (Thorsten Leemhuis)]

On 30.05.24 08:53, Kalle Valo wrote:
> Kalle Valo <kvalo@kernel.org> writes:
>> Kalle Valo <kvalo@kernel.org> writes:

> I found my mistake and was able to finish the bisect. This seems to be
> the commit causing my problems:
> # first bad commit: [7e89efc6e9e402839643cb297bab14055c547f07] PCI: Lock upstream bridge for pci_reset_function()

FWIW in case you missed that: there are a few other discussions related
to that commit already:
https://lore.kernel.org/all/?q=7e89efc6e*

And a patch with a Fixes: tag for that commit, too:
https://lore.kernel.org/all/171659995361.845588.6664390911348526329.stgit@dwillia2-xfh.jf.intel.com/

Ciao, Thorsten

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Dan Williams]

Kalle Valo wrote:
> Kalle Valo <kvalo@kernel.org> writes:
> 
> > Kalle Valo <kvalo@kernel.org> writes:
> >
> >> Yesterday I run our ath11k regression tests with v6.10-rc1 and our
> >> simple ath11k module reload stress started failing reliably with various
> >> KASAN errors. The test removes and inserts ath11k and other wireless
> >> modules in a loop. Usually I run it at least 100 times, some times even
> >> more, and no issues until yesterday.
> >>
> >> I have verified that the last wireless-next pull request (tag
> >> wireless-next-2024-05-08) works without issues and v6.10-rc1 fails
> >> always, usually within 50 module reload loops. From this I'm _guessing_
> >> that we have a regression outside wireless, most probably introduced
> >> between v6.9 and v6.10-rc1. But of course I cannot be sure of anything
> >> yet.
> >>
> >> I see different KASAN warnings and lockdep seems to be always visible in
> >> the stack traces. I think I can reproduce the issue within 15 minutes or
> >> so. Before I start bisecting has anyone else seen anything similar? Or
> >> any suggestions how to debug this further?
> >>
> >> I have included some crash logs below, they are retrieved using
> >> netconsole. Here's a summary of the errors:
> >>
> >> [ 159.970765] KASAN: maybe wild-memory-access in range
> >> [0xbbbbbbbbbbbbbbb8-0xbbbbbbbbbbbbbbbf]
> >> [  700.017632] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0
> >> [  224.695821] BUG: KASAN: slab-out-of-bounds in lockdep_register_key+0x755/0x8f0
> >> [  259.666542] BUG: KASAN: slab-use-after-free in lockdep_register_key+0x755/0x8f0

The proposed fix for that is here:

http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Dan Williams <dan.j.williams@intel.com> writes:

> Kalle Valo wrote:
>
>> Kalle Valo <kvalo@kernel.org> writes:
>> 
>> > Kalle Valo <kvalo@kernel.org> writes:
>> >
>> >> Yesterday I run our ath11k regression tests with v6.10-rc1 and our
>> >> simple ath11k module reload stress started failing reliably with various
>> >> KASAN errors. The test removes and inserts ath11k and other wireless
>> >> modules in a loop. Usually I run it at least 100 times, some times even
>> >> more, and no issues until yesterday.
>> >>
>> >> I have verified that the last wireless-next pull request (tag
>> >> wireless-next-2024-05-08) works without issues and v6.10-rc1 fails
>> >> always, usually within 50 module reload loops. From this I'm _guessing_
>> >> that we have a regression outside wireless, most probably introduced
>> >> between v6.9 and v6.10-rc1. But of course I cannot be sure of anything
>> >> yet.
>> >>
>> >> I see different KASAN warnings and lockdep seems to be always visible in
>> >> the stack traces. I think I can reproduce the issue within 15 minutes or
>> >> so. Before I start bisecting has anyone else seen anything similar? Or
>> >> any suggestions how to debug this further?
>> >>
>> >> I have included some crash logs below, they are retrieved using
>> >> netconsole. Here's a summary of the errors:
>> >>
>> >> [ 159.970765] KASAN: maybe wild-memory-access in range
>> >> [0xbbbbbbbbbbbbbbb8-0xbbbbbbbbbbbbbbbf]
>> >> [  700.017632] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0
>> >> [  224.695821] BUG: KASAN: slab-out-of-bounds in lockdep_register_key+0x755/0x8f0
>> >> [ 259.666542] BUG: KASAN: slab-use-after-free in
>> >> lockdep_register_key+0x755/0x8f0
>
> The proposed fix for that is here:
>
> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch

I get "Not Found" from that link, is there a typo?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Kalle Valo <kvalo@kernel.org> writes:

> Dan Williams <dan.j.williams@intel.com> writes:
>
>> Kalle Valo wrote:
>>
>>> Kalle Valo <kvalo@kernel.org> writes:
>>> 
>>> > Kalle Valo <kvalo@kernel.org> writes:
>>> >
>>> >> Yesterday I run our ath11k regression tests with v6.10-rc1 and our
>>> >> simple ath11k module reload stress started failing reliably with various
>>> >> KASAN errors. The test removes and inserts ath11k and other wireless
>>> >> modules in a loop. Usually I run it at least 100 times, some times even
>>> >> more, and no issues until yesterday.
>>> >>
>>> >> I have verified that the last wireless-next pull request (tag
>>> >> wireless-next-2024-05-08) works without issues and v6.10-rc1 fails
>>> >> always, usually within 50 module reload loops. From this I'm _guessing_
>>> >> that we have a regression outside wireless, most probably introduced
>>> >> between v6.9 and v6.10-rc1. But of course I cannot be sure of anything
>>> >> yet.
>>> >>
>>> >> I see different KASAN warnings and lockdep seems to be always visible in
>>> >> the stack traces. I think I can reproduce the issue within 15 minutes or
>>> >> so. Before I start bisecting has anyone else seen anything similar? Or
>>> >> any suggestions how to debug this further?
>>> >>
>>> >> I have included some crash logs below, they are retrieved using
>>> >> netconsole. Here's a summary of the errors:
>>> >>
>>> >> [ 159.970765] KASAN: maybe wild-memory-access in range
>>> >> [0xbbbbbbbbbbbbbbb8-0xbbbbbbbbbbbbbbbf]
>>> >> [  700.017632] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0
>>> >> [ 224.695821] BUG: KASAN: slab-out-of-bounds in
>>> >> lockdep_register_key+0x755/0x8f0
>>> >> [ 259.666542] BUG: KASAN: slab-use-after-free in
>>> >> lockdep_register_key+0x755/0x8f0
>>
>> The proposed fix for that is here:
>>
>> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
>
> I get "Not Found" from that link, is there a typo?

I found this fix from for-linus branch:

# PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560

But at least that doesn't fix my crash.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Dan Williams]

Kalle Valo wrote:
[..]
> >> The proposed fix for that is here:
> >>
> >> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
> >
> > I get "Not Found" from that link, is there a typo?
> 
> I found this fix from for-linus branch:
> 
> # PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560
> 
> But at least that doesn't fix my crash.

Sorry for the broken link I mistakenly used a message-id from an
internal thread with the intel.com reporter. However, it is moot now
because the new direction is to revert the lockdep infrastructure:

https://lore.kernel.org/r/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com

(that link works...)

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Dan Williams <dan.j.williams@intel.com> writes:

> Kalle Valo wrote:
> [..]
>> >> The proposed fix for that is here:
>> >>
>> >> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
>> >
>> > I get "Not Found" from that link, is there a typo?
>> 
>> I found this fix from for-linus branch:
>> 
>> # PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
>> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560
>> 
>> But at least that doesn't fix my crash.
>
> Sorry for the broken link I mistakenly used a message-id from an
> internal thread with the intel.com reporter. However, it is moot now
> because the new direction is to revert the lockdep infrastructure:
>
> https://lore.kernel.org/r/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com
>
> (that link works...)

Thanks, that links works :) I did a quick test with the three patches
and I didn't see any crashes anymore. But to be confident I need to run
overnight tests, I'll provide my Tested-by after that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Kalle Valo <kvalo@kernel.org> writes:

> Dan Williams <dan.j.williams@intel.com> writes:
>
>> Kalle Valo wrote:
>> [..]
>>> >> The proposed fix for that is here:
>>> >>
>>> >> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
>>> >
>>> > I get "Not Found" from that link, is there a typo?
>>> 
>>> I found this fix from for-linus branch:
>>> 
>>> # PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
>>> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560
>>> 
>>> But at least that doesn't fix my crash.
>>
>> Sorry for the broken link I mistakenly used a message-id from an
>> internal thread with the intel.com reporter. However, it is moot now
>> because the new direction is to revert the lockdep infrastructure:
>>
>> https://lore.kernel.org/r/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com
>>
>> (that link works...)
>
> Thanks, that links works :) I did a quick test with the three patches
> and I didn't see any crashes anymore. But to be confident I need to run
> overnight tests, I'll provide my Tested-by after that.

Ok, I'm now quite confident that the issues I saw are solved so:

Tested-by: Kalle Valo <kvalo@kernel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Bjorn Helgaas]

On Sat, Jun 01, 2024 at 11:39:03AM +0300, Kalle Valo wrote:
> Kalle Valo <kvalo@kernel.org> writes:
> 
> > Dan Williams <dan.j.williams@intel.com> writes:
> >
> >> Kalle Valo wrote:
> >> [..]
> >>> >> The proposed fix for that is here:
> >>> >>
> >>> >> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
> >>> >
> >>> > I get "Not Found" from that link, is there a typo?
> >>> 
> >>> I found this fix from for-linus branch:
> >>> 
> >>> # PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560
> >>> 
> >>> But at least that doesn't fix my crash.
> >>
> >> Sorry for the broken link I mistakenly used a message-id from an
> >> internal thread with the intel.com reporter. However, it is moot now
> >> because the new direction is to revert the lockdep infrastructure:
> >>
> >> https://lore.kernel.org/r/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com
> >>
> >> (that link works...)
> >
> > Thanks, that links works :) I did a quick test with the three patches
> > and I didn't see any crashes anymore. But to be confident I need to run
> > overnight tests, I'll provide my Tested-by after that.
> 
> Ok, I'm now quite confident that the issues I saw are solved so:
> 
> Tested-by: Kalle Valo <kvalo@kernel.org>

Thanks for reporting the issue and testing the fix!  Can you please
respond with your Tested-by to the actual patch(es) you tested?

Bjorn

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Bjorn Helgaas <helgaas@kernel.org> writes:

> On Sat, Jun 01, 2024 at 11:39:03AM +0300, Kalle Valo wrote:
>
>> Kalle Valo <kvalo@kernel.org> writes:
>> 
>> > Dan Williams <dan.j.williams@intel.com> writes:
>> >
>> >> Kalle Valo wrote:
>> >> [..]
>> >>> >> The proposed fix for that is here:
>> >>> >>
>> >>> >> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
>> >>> >
>> >>> > I get "Not Found" from that link, is there a typo?
>> >>> 
>> >>> I found this fix from for-linus branch:
>> >>> 
>> >>> # PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560
>> >>> 
>> >>> But at least that doesn't fix my crash.
>> >>
>> >> Sorry for the broken link I mistakenly used a message-id from an
>> >> internal thread with the intel.com reporter. However, it is moot now
>> >> because the new direction is to revert the lockdep infrastructure:
>> >>
>> >> https://lore.kernel.org/r/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com
>> >>
>> >> (that link works...)
>> >
>> > Thanks, that links works :) I did a quick test with the three patches
>> > and I didn't see any crashes anymore. But to be confident I need to run
>> > overnight tests, I'll provide my Tested-by after that.
>> 
>> Ok, I'm now quite confident that the issues I saw are solved so:
>> 
>> Tested-by: Kalle Valo <kvalo@kernel.org>
>
> Thanks for reporting the issue and testing the fix!  Can you please
> respond with your Tested-by to the actual patch(es) you tested?

Not easily as I'm not subscribed to linux-pci list and I haven't
researched how to import mbox files to my mailer :) So feel free to
ignore my Tested-by tag in this case.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Dan Williams]

Kalle Valo wrote:
[..]
> > Thanks for reporting the issue and testing the fix!  Can you please
> > respond with your Tested-by to the actual patch(es) you tested?
> 
> Not easily as I'm not subscribed to linux-pci list and I haven't
> researched how to import mbox files to my mailer :) So feel free to
> ignore my Tested-by tag in this case.

I have had success with "b4 mbox" and importing that into Evolution, but
your mileage may vary with your mailer setup.

Re: [regression] BUG: KASAN: use-after-free in lockdep_register_key+0x755/0x8f0

[Kalle Valo]

Dan Williams <dan.j.williams@intel.com> writes:

> Kalle Valo wrote:
> [..]
>> > Thanks for reporting the issue and testing the fix!  Can you please
>> > respond with your Tested-by to the actual patch(es) you tested?
>> 
>> Not easily as I'm not subscribed to linux-pci list and I haven't
>> researched how to import mbox files to my mailer :) So feel free to
>> ignore my Tested-by tag in this case.
>
> I have had success with "b4 mbox" and importing that into Evolution, but
> your mileage may vary with your mailer setup.

Heh, I'm old school and don't use anything modern like Evolution :) But
it was actually really easy with Gnus ('G f') and looks like I managed
to do it succesfully now:

https://lore.kernel.org/all/87h6e9t9qt.fsf@kernel.org/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches