From: Shyam Saini <shyamsaini@linux.microsoft.com>
To: jingoohan1@gmail.com
Cc: Sergey.Semin@baikalelectronics.ru, fancer.lancer@gmail.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
linux-pci@vger.kernel.org, code@tyhicks.com,
apais@linux.microsoft.com, bboscaccy@linux.microsoft.com,
okaya@kernel.org, shyamsaini@linux.microsoft.com,
srivatsa@csail.mit.edu, tballasi@linux.microsoft.com,
vijayb@linux.microsoft.com
Subject: [PATCH V2] drivers: pci: dwc: configure multiple atu regions
Date: Mon, 10 Jun 2024 16:50:48 -0700 [thread overview]
Message-ID: <20240610235048.319266-1-shyamsaini@linux.microsoft.com> (raw)
Before this change, the dwc PCIe driver configures only 1 ATU region,
which is sufficient for the devices with PCIe memory <= 4GB. However,
the driver probe fails when device uses more than 4GB of pcie memory.
Fix this by configuring multiple ATU regions for the devices which
use more than 4GB of PCIe memory.
Given each 4GB block of memory requires a new ATU region, the total
number of ATU regions are calculated using the size of PCIe device
tree node's MEM64 pref range size.
Signed-off-by: Shyam Saini <shyamsaini@linux.microsoft.com>
---
.../pci/controller/dwc/pcie-designware-host.c | 38 +++++++++++++++++--
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index d15a5c2d5b48..bed0b189b6ad 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -652,6 +652,33 @@ static struct pci_ops dw_pcie_ops = {
.write = pci_generic_config_write,
};
+static int dw_pcie_num_atu_regions(struct resource_entry *entry)
+{
+ return DIV_ROUND_UP(resource_size(entry->res), SZ_4G);
+}
+
+static int dw_pcie_prog_outbound_atu_multi(struct dw_pcie *pci, int type,
+ struct resource_entry *entry)
+{
+ int idx, ret, num_regions;
+
+ num_regions = dw_pcie_num_atu_regions(entry);
+
+ for (idx = 0; idx < num_regions; idx++) {
+ dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, idx);
+ ret = dw_pcie_prog_outbound_atu(pci, idx, PCIE_ATU_TYPE_MEM,
+ entry->res->start,
+ entry->res->start - entry->offset,
+ resource_size(entry->res)/4);
+
+ if (ret)
+ goto err;
+ }
+
+err:
+ return ret;
+}
+
static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
{
struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
@@ -682,10 +709,13 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
if (pci->num_ob_windows <= ++i)
break;
- ret = dw_pcie_prog_outbound_atu(pci, i, PCIE_ATU_TYPE_MEM,
- entry->res->start,
- entry->res->start - entry->offset,
- resource_size(entry->res));
+ if (resource_size(entry->res) > SZ_4G)
+ ret = dw_pcie_prog_outbound_atu_multi(pci, PCIE_ATU_TYPE_MEM, entry);
+ else
+ ret = dw_pcie_prog_outbound_atu(pci, i, PCIE_ATU_TYPE_MEM,
+ entry->res->start,
+ entry->res->start - entry->offset,
+ resource_size(entry->res));
if (ret) {
dev_err(pci->dev, "Failed to set MEM range %pr\n",
entry->res);
--
2.34.1
next reply other threads:[~2024-06-10 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 23:50 Shyam Saini [this message]
2024-06-12 6:07 ` [PATCH V2] drivers: pci: dwc: configure multiple atu regions Manivannan Sadhasivam
2024-06-13 22:47 ` Shyam Saini
2024-06-14 10:40 ` Serge Semin
2024-06-26 8:26 ` Shyam Saini
2024-06-28 17:27 ` Serge Semin
2024-06-14 12:26 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610235048.319266-1-shyamsaini@linux.microsoft.com \
--to=shyamsaini@linux.microsoft.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=apais@linux.microsoft.com \
--cc=bboscaccy@linux.microsoft.com \
--cc=code@tyhicks.com \
--cc=fancer.lancer@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=okaya@kernel.org \
--cc=robh@kernel.org \
--cc=srivatsa@csail.mit.edu \
--cc=tballasi@linux.microsoft.com \
--cc=vijayb@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox