* [PATCH 1/1] PCI: Remove extra parenthesis from calculate_mem_align()
@ 2024-06-12 9:32 Ilpo Järvinen
2024-06-12 19:51 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2024-06-12 9:32 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci, linux-kernel; +Cc: Ilpo Järvinen
RHS of <<= does not need parenthesis so remove them.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
This patch can be folded into the commit 658bf5d36dc5 ("PCI: Make
minimum bridge window alignment reference more obvious") in
pci/resource if so desired.
---
drivers/pci/setup-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 11ee60b9ca71..23082bc0ca37 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -960,7 +960,7 @@ static inline resource_size_t calculate_mem_align(resource_size_t *aligns,
for (order = 0; order <= max_order; order++) {
resource_size_t align1 = 1;
- align1 <<= (order + __ffs(SZ_1M));
+ align1 <<= order + __ffs(SZ_1M);
if (!align)
min_align = align1;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] PCI: Remove extra parenthesis from calculate_mem_align()
2024-06-12 9:32 [PATCH 1/1] PCI: Remove extra parenthesis from calculate_mem_align() Ilpo Järvinen
@ 2024-06-12 19:51 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2024-06-12 19:51 UTC (permalink / raw)
To: Ilpo Järvinen; +Cc: Bjorn Helgaas, linux-pci, linux-kernel
On Wed, Jun 12, 2024 at 12:32:49PM +0300, Ilpo Järvinen wrote:
> RHS of <<= does not need parenthesis so remove them.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Squashed, thanks!
> ---
>
> This patch can be folded into the commit 658bf5d36dc5 ("PCI: Make
> minimum bridge window alignment reference more obvious") in
> pci/resource if so desired.
> ---
> drivers/pci/setup-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 11ee60b9ca71..23082bc0ca37 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -960,7 +960,7 @@ static inline resource_size_t calculate_mem_align(resource_size_t *aligns,
> for (order = 0; order <= max_order; order++) {
> resource_size_t align1 = 1;
>
> - align1 <<= (order + __ffs(SZ_1M));
> + align1 <<= order + __ffs(SZ_1M);
>
> if (!align)
> min_align = align1;
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-12 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-12 9:32 [PATCH 1/1] PCI: Remove extra parenthesis from calculate_mem_align() Ilpo Järvinen
2024-06-12 19:51 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox