* [PATCH] misc: pci_endpoint_test: Remove some unused functions
@ 2024-05-16 8:36 Jiapeng Chong
2024-07-01 8:10 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2024-05-16 8:36 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: kw, kishon, arnd, gregkh, linux-pci, linux-kernel, Jiapeng Chong,
Abaci Robot
These functions are defined in the pci_endpoint_test.c file, but not
called elsewhere, so delete these unused functions.
drivers/misc/pci_endpoint_test.c:144:19: warning: unused function 'pci_endpoint_test_bar_readl'.
drivers/misc/pci_endpoint_test.c:150:20: warning: unused function 'pci_endpoint_test_bar_writel'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9064
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/misc/pci_endpoint_test.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 4f3ec1f2ba9f..5d98b82da17a 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -141,18 +141,6 @@ static inline void pci_endpoint_test_writel(struct pci_endpoint_test *test,
writel(value, test->base + offset);
}
-static inline u32 pci_endpoint_test_bar_readl(struct pci_endpoint_test *test,
- int bar, int offset)
-{
- return readl(test->bar[bar] + offset);
-}
-
-static inline void pci_endpoint_test_bar_writel(struct pci_endpoint_test *test,
- int bar, u32 offset, u32 value)
-{
- writel(value, test->bar[bar] + offset);
-}
-
static irqreturn_t pci_endpoint_test_irqhandler(int irq, void *dev_id)
{
struct pci_endpoint_test *test = dev_id;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: pci_endpoint_test: Remove some unused functions
2024-05-16 8:36 [PATCH] misc: pci_endpoint_test: Remove some unused functions Jiapeng Chong
@ 2024-07-01 8:10 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2024-07-01 8:10 UTC (permalink / raw)
To: Jiapeng Chong
Cc: manivannan.sadhasivam, kishon, arnd, gregkh, linux-pci,
linux-kernel, Abaci Robot
Hello,
> These functions are defined in the pci_endpoint_test.c file, but not
> called elsewhere, so delete these unused functions.
>
> drivers/misc/pci_endpoint_test.c:144:19: warning: unused function 'pci_endpoint_test_bar_readl'.
> drivers/misc/pci_endpoint_test.c:150:20: warning: unused function 'pci_endpoint_test_bar_writel'.
Are you sure these aren't used?
Index File Line Content
0 drivers/misc/pci_endpoint_test.c 143 static inline u32 pci_endpoint_test_bar_readl(struct pci_endpoint_test *test,
1 drivers/misc/pci_endpoint_test.c 296 val = pci_endpoint_test_bar_readl(test, barno, j);
Index File Line Content
0 drivers/misc/pci_endpoint_test.c 149 static inline void pci_endpoint_test_bar_writel(struct pci_endpoint_test *test,
1 drivers/misc/pci_endpoint_test.c 292 pci_endpoint_test_bar_writel(test, barno, j,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-01 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 8:36 [PATCH] misc: pci_endpoint_test: Remove some unused functions Jiapeng Chong
2024-07-01 8:10 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox