Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Nirmal Patel <nirmal.patel@linux.intel.com>
To: <linux-pci@vger.kernel.org>, paul.m.stillwell.jr@intel.com
Cc: Nirmal Patel <nirmal.patel@linux.intel.com>,
	Jim Harris <james.r.harris@intel.com>
Subject: [PATCH] PCI: fixup PCI_INTERRUPT_LINE for VMD downstream devices
Date: Wed, 24 Jul 2024 10:00:40 -0700	[thread overview]
Message-ID: <20240724170040.5193-1-nirmal.patel@linux.intel.com> (raw)

VMD does not support legacy interrupts for devices downstream from a
VMD endpoint. So initialize the PCI_INTERRUPT_LINE to 0 for these
devices to ensure we don't try to set up a legacy irq for them.

Note: This patch was proposed by Jim, I am trying to upstream it.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Signed-off-by: Nirmal Patel <nirmal.patel@linux.intel.com>
---
 arch/x86/pci/fixup.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
index b33afb240601..a3b34a256e7f 100644
--- a/arch/x86/pci/fixup.c
+++ b/arch/x86/pci/fixup.c
@@ -653,6 +653,20 @@ static void quirk_no_aersid(struct pci_dev *pdev)
 DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID,
 			      PCI_CLASS_BRIDGE_PCI, 8, quirk_no_aersid);
 
+#if IS_ENABLED(CONFIG_VMD)
+/* 
+ * VMD does not support legacy interrupts for downstream devices.
+ * So PCI_INTERRPUT_LINE needs to be initialized to 0 to ensure OS
+ * doesn't try to configure a legacy irq.
+ */
+static void quirk_vmd_interrupt_line(struct pci_dev *dev)
+{
+	if (is_vmd(dev->bus))
+		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, 0);
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, quirk_vmd_interrupt_line);
+#endif
+
 static void quirk_intel_th_dnv(struct pci_dev *dev)
 {
 	struct resource *r = &dev->resource[4];
-- 
2.39.1


             reply	other threads:[~2024-07-24 17:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 17:00 Nirmal Patel [this message]
2024-07-24 18:36 ` [PATCH] PCI: fixup PCI_INTERRUPT_LINE for VMD downstream devices Christoph Hellwig
2024-07-31 19:21   ` Nirmal Patel
2024-07-24 19:10 ` Bjorn Helgaas
2024-07-25  4:10   ` Manivannan Sadhasivam
2024-07-25 21:22     ` Nirmal Patel
2024-07-29 20:08     ` Nirmal Patel
2024-07-30  5:28       ` Manivannan Sadhasivam
2024-07-30 17:51         ` Nirmal Patel
2024-07-31  3:07           ` Manivannan Sadhasivam
2024-08-01 18:57             ` Nirmal Patel
2024-07-29 20:10   ` Nirmal Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240724170040.5193-1-nirmal.patel@linux.intel.com \
    --to=nirmal.patel@linux.intel.com \
    --cc=james.r.harris@intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=paul.m.stillwell.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox