From: Christoph Hellwig <hch@infradead.org>
To: Nirmal Patel <nirmal.patel@linux.intel.com>
Cc: linux-pci@vger.kernel.org, paul.m.stillwell.jr@intel.com,
Jim Harris <james.r.harris@intel.com>
Subject: Re: [PATCH] PCI: fixup PCI_INTERRUPT_LINE for VMD downstream devices
Date: Wed, 24 Jul 2024 11:36:31 -0700 [thread overview]
Message-ID: <ZqFJr7Y3Vemjv2SC@infradead.org> (raw)
In-Reply-To: <20240724170040.5193-1-nirmal.patel@linux.intel.com>
On Wed, Jul 24, 2024 at 10:00:40AM -0700, Nirmal Patel wrote:
> +#if IS_ENABLED(CONFIG_VMD)
> +/*
> + * VMD does not support legacy interrupts for downstream devices.
> + * So PCI_INTERRPUT_LINE needs to be initialized to 0 to ensure OS
> + * doesn't try to configure a legacy irq.
> + */
The wording is a bit weird, Linux is the OS normally. Or is this
about guest OSes in virtualized environments? Given how VMD bypasses
a lot of boundaries can we even assign individual devices to VFIO?
And if so is that actually safe or should we prohibit it?
next prev parent reply other threads:[~2024-07-24 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 17:00 [PATCH] PCI: fixup PCI_INTERRUPT_LINE for VMD downstream devices Nirmal Patel
2024-07-24 18:36 ` Christoph Hellwig [this message]
2024-07-31 19:21 ` Nirmal Patel
2024-07-24 19:10 ` Bjorn Helgaas
2024-07-25 4:10 ` Manivannan Sadhasivam
2024-07-25 21:22 ` Nirmal Patel
2024-07-29 20:08 ` Nirmal Patel
2024-07-30 5:28 ` Manivannan Sadhasivam
2024-07-30 17:51 ` Nirmal Patel
2024-07-31 3:07 ` Manivannan Sadhasivam
2024-08-01 18:57 ` Nirmal Patel
2024-07-29 20:10 ` Nirmal Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqFJr7Y3Vemjv2SC@infradead.org \
--to=hch@infradead.org \
--cc=james.r.harris@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=nirmal.patel@linux.intel.com \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox