Re: [PATCH] s390/pci: Stop usurping pdev->dev.groups

[Konstantin Ryabitsev <konstantin@linuxfoundation.org>]

On Tue, Aug 06, 2024 at 09:55:38PM GMT, Lukas Wunner wrote:
> [cc += Konstantin]
> 
> On Tue, Aug 06, 2024 at 02:30:55PM -0500, Bjorn Helgaas wrote:
> > On Mon, Aug 05, 2024 at 05:24:05PM +0200, Lukas Wunner wrote:
> > > Bjorn suggests using pdev->dev.groups for attribute_groups constructed
> > > on PCI device enumeration:
> > > 
> > >    "Is it feasible to build an attribute group in pci_doe_init() and
> > >     add it to dev->groups so device_add() will automatically add them?"
> > >     https://msgid.link/20231019165829.GA1381099@bhelgaas
> > 
> > Huh, another new archive link format.  I guess I need to be educated
> > about this.  I see 127734e23aed ("Documentation: best practices for
> > using Link trailers"), which added the only mentions in the tree,
> > although it only mentions "https://patch.msgid.link" and specifically
> > in the context of the origin of a patch, which leaves it clear as mud
> > for me.
> 
> I merely chose that because it's shorter than lore.kernel.org and makes
> it more obvious that it's a Message-ID link to the mailing list archive.
> 
> I'm not sure whether that goes against any best practices associated
> with the msgid.link domain and whether it's going to work as long as
> lore.kernel.org.  Hopefully Konstantin can comment on that.

I think it's perfectly fine to use msgid.link URLs for general links to
mailing list archives. The reason we introduced patch.msgid.link was
specifically to distinguish general links to discussions from links pointing
at the origin of the commit.

-K