From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-pci@vger.kernel.org,
Alistair Francis <alistair23@gmail.com>,
Jonathan.Cameron@huawei.com, alex.williamson@redhat.com,
christian.koenig@amd.com, kch@nvidia.com,
gregkh@linuxfoundation.org, logang@deltatee.com,
chaitanyak@nvidia.com, rdunlap@infradead.org,
Alistair Francis <alistair.francis@wdc.com>,
Sebastian Ott <sebott@redhat.com>
Subject: Re: [PATCH] s390/pci: Stop usurping pdev->dev.groups
Date: Tue, 6 Aug 2024 21:55:38 +0200 [thread overview]
Message-ID: <ZrJ_uqL-2wf3wV9d@wunner.de> (raw)
In-Reply-To: <20240806193055.GA73910@bhelgaas>
[cc += Konstantin]
On Tue, Aug 06, 2024 at 02:30:55PM -0500, Bjorn Helgaas wrote:
> On Mon, Aug 05, 2024 at 05:24:05PM +0200, Lukas Wunner wrote:
> > Bjorn suggests using pdev->dev.groups for attribute_groups constructed
> > on PCI device enumeration:
> >
> > "Is it feasible to build an attribute group in pci_doe_init() and
> > add it to dev->groups so device_add() will automatically add them?"
> > https://msgid.link/20231019165829.GA1381099@bhelgaas
>
> Huh, another new archive link format. I guess I need to be educated
> about this. I see 127734e23aed ("Documentation: best practices for
> using Link trailers"), which added the only mentions in the tree,
> although it only mentions "https://patch.msgid.link" and specifically
> in the context of the origin of a patch, which leaves it clear as mud
> for me.
I merely chose that because it's shorter than lore.kernel.org and makes
it more obvious that it's a Message-ID link to the mailing list archive.
I'm not sure whether that goes against any best practices associated
with the msgid.link domain and whether it's going to work as long as
lore.kernel.org. Hopefully Konstantin can comment on that.
Otherwise feel free to replace when applying.
Thanks,
Lukas
next prev parent reply other threads:[~2024-08-06 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 15:24 [PATCH] s390/pci: Stop usurping pdev->dev.groups Lukas Wunner
2024-08-06 19:30 ` Bjorn Helgaas
2024-08-06 19:55 ` Lukas Wunner [this message]
2024-08-07 18:08 ` Konstantin Ryabitsev
2024-08-07 15:44 ` Niklas Schnelle
2024-08-09 20:02 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrJ_uqL-2wf3wV9d@wunner.de \
--to=lukas@wunner.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=agordeev@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=borntraeger@linux.ibm.com \
--cc=chaitanyak@nvidia.com \
--cc=christian.koenig@amd.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=helgaas@kernel.org \
--cc=kch@nvidia.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=rdunlap@infradead.org \
--cc=schnelle@linux.ibm.com \
--cc=sebott@redhat.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox