Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -next] PCI: Remove two unused declarations
Date: Wed, 28 Aug 2024 16:25:09 -0500	[thread overview]
Message-ID: <20240828212509.GA39447@bhelgaas> (raw)
In-Reply-To: <20240824100331.586036-1-yuehaibing@huawei.com>

On Sat, Aug 24, 2024 at 06:03:31PM +0800, Yue Haibing wrote:
> Commit b67ea76172d4 ("PCI / ACPI / PM: Platform support for PCI PME
> wake-up") declared but never implemented __pci_pme_wakeup().
> Commit fd00faa375fb ("PCI/VPD: Embed struct pci_vpd in struct pci_dev")
> removed pci_vpd_release() but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Split into two patches (PCI/PM and PCI/VPD) and applied to pci/misc
for v6.12, thank you!

> ---
> v2: Add pci_vpd_release() history
> ---
>  drivers/pci/pci.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 0e9b1c7b94a5..4c284c55a0c5 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -124,7 +124,6 @@ void pcie_clear_device_status(struct pci_dev *dev);
>  void pcie_clear_root_pme_status(struct pci_dev *dev);
>  bool pci_check_pme_status(struct pci_dev *dev);
>  void pci_pme_wakeup_bus(struct pci_bus *bus);
> -int __pci_pme_wakeup(struct pci_dev *dev, void *ign);
>  void pci_pme_restore(struct pci_dev *dev);
>  bool pci_dev_need_resume(struct pci_dev *dev);
>  void pci_dev_adjust_pme(struct pci_dev *dev);
> @@ -169,7 +168,6 @@ static inline bool pcie_downstream_port(const struct pci_dev *dev)
>  }
>  
>  void pci_vpd_init(struct pci_dev *dev);
> -void pci_vpd_release(struct pci_dev *dev);
>  extern const struct attribute_group pci_dev_vpd_attr_group;
>  
>  /* PCI Virtual Channel */
> -- 
> 2.34.1
> 

      reply	other threads:[~2024-08-28 21:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-24 10:03 [PATCH v2 -next] PCI: Remove two unused declarations Yue Haibing
2024-08-28 21:25 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828212509.GA39447@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox