[PATCH v2 -next] PCI: Remove two unused declarations

[PATCH v2 -next] PCI: Remove two unused declarations

[Yue Haibing]

Commit b67ea76172d4 ("PCI / ACPI / PM: Platform support for PCI PME
wake-up") declared but never implemented __pci_pme_wakeup().
Commit fd00faa375fb ("PCI/VPD: Embed struct pci_vpd in struct pci_dev")
removed pci_vpd_release() but leave declaration.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
v2: Add pci_vpd_release() history
---
 drivers/pci/pci.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 0e9b1c7b94a5..4c284c55a0c5 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -124,7 +124,6 @@ void pcie_clear_device_status(struct pci_dev *dev);
 void pcie_clear_root_pme_status(struct pci_dev *dev);
 bool pci_check_pme_status(struct pci_dev *dev);
 void pci_pme_wakeup_bus(struct pci_bus *bus);
-int __pci_pme_wakeup(struct pci_dev *dev, void *ign);
 void pci_pme_restore(struct pci_dev *dev);
 bool pci_dev_need_resume(struct pci_dev *dev);
 void pci_dev_adjust_pme(struct pci_dev *dev);
@@ -169,7 +168,6 @@ static inline bool pcie_downstream_port(const struct pci_dev *dev)
 }
 
 void pci_vpd_init(struct pci_dev *dev);
-void pci_vpd_release(struct pci_dev *dev);
 extern const struct attribute_group pci_dev_vpd_attr_group;
 
 /* PCI Virtual Channel */
-- 
2.34.1

Re: [PATCH v2 -next] PCI: Remove two unused declarations

[Bjorn Helgaas]

On Sat, Aug 24, 2024 at 06:03:31PM +0800, Yue Haibing wrote:
> Commit b67ea76172d4 ("PCI / ACPI / PM: Platform support for PCI PME
> wake-up") declared but never implemented __pci_pme_wakeup().
> Commit fd00faa375fb ("PCI/VPD: Embed struct pci_vpd in struct pci_dev")
> removed pci_vpd_release() but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Split into two patches (PCI/PM and PCI/VPD) and applied to pci/misc
for v6.12, thank you!

> ---
> v2: Add pci_vpd_release() history
> ---
>  drivers/pci/pci.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 0e9b1c7b94a5..4c284c55a0c5 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -124,7 +124,6 @@ void pcie_clear_device_status(struct pci_dev *dev);
>  void pcie_clear_root_pme_status(struct pci_dev *dev);
>  bool pci_check_pme_status(struct pci_dev *dev);
>  void pci_pme_wakeup_bus(struct pci_bus *bus);
> -int __pci_pme_wakeup(struct pci_dev *dev, void *ign);
>  void pci_pme_restore(struct pci_dev *dev);
>  bool pci_dev_need_resume(struct pci_dev *dev);
>  void pci_dev_adjust_pme(struct pci_dev *dev);
> @@ -169,7 +168,6 @@ static inline bool pcie_downstream_port(const struct pci_dev *dev)
>  }
>  
>  void pci_vpd_init(struct pci_dev *dev);
> -void pci_vpd_release(struct pci_dev *dev);
>  extern const struct attribute_group pci_dev_vpd_attr_group;
>  
>  /* PCI Virtual Channel */
> -- 
> 2.34.1
>