From: Shuai Xue <xueshuai@linux.alibaba.com>
To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: bhelgaas@google.com, mahesh@linux.ibm.com, oohall@gmail.com,
sathyanarayanan.kuppuswamy@linux.intel.com,
xueshuai@linux.alibaba.com
Subject: [RFC PATCH v1 0/2] PCI/AER: report fatal errors of RCiEP and EP if link recoverd
Date: Wed, 6 Nov 2024 17:03:37 +0800 [thread overview]
Message-ID: <20241106090339.24920-1-xueshuai@linux.alibaba.com> (raw)
The AER driver has historically avoided reading the configuration space of an
endpoint or RCiEP that reported a fatal error, considering the link to that
device unreliable. Consequently, when a fatal error occurs, the AER and DPC
drivers do not report specific error types, resulting in logs like:
[ 245.281980] pcieport 0000:30:03.0: EDR: EDR event received
[ 245.287466] pcieport 0000:30:03.0: DPC: containment event, status:0x0005 source:0x3400
[ 245.295372] pcieport 0000:30:03.0: DPC: ERR_FATAL detected
[ 245.300849] pcieport 0000:30:03.0: AER: broadcast error_detected message
[ 245.307540] nvme nvme0: frozen state error detected, reset controller
[ 245.722582] nvme 0000:34:00.0: ready 0ms after DPC
[ 245.727365] pcieport 0000:30:03.0: AER: broadcast slot_reset message
But, if the link recovered after hot reset, we can safely access AER status of
the error device. In such case, report fatal error which helps to figure out the
error root case.
- Patch 1/2 identifies the error device by SOURCE ID register
- Patch 2/3 reports the AER status if link recoverd.
After this patch set, the logs like:
[ 414.356755] pcieport 0000:30:03.0: EDR: EDR event received
[ 414.362240] pcieport 0000:30:03.0: DPC: containment event, status:0x0005 source:0x3400
[ 414.370148] pcieport 0000:30:03.0: DPC: ERR_FATAL detected
[ 414.375642] pcieport 0000:30:03.0: AER: broadcast error_detected message
[ 414.382335] nvme nvme0: frozen state error detected, reset controller
[ 414.645413] pcieport 0000:30:03.0: waiting 100 ms for downstream link, after activation
[ 414.788016] nvme 0000:34:00.0: ready 0ms after DPC
[ 414.796975] nvme 0000:34:00.0: PCIe Bus Error: severity=Uncorrectable (Fatal), type=Data Link Layer, (Receiver ID)
[ 414.807312] nvme 0000:34:00.0: device [144d:a804] error status/mask=00000010/00504000
[ 414.815305] nvme 0000:34:00.0: [ 4] DLP (First)
[ 414.821768] pcieport 0000:30:03.0: AER: broadcast slot_reset message
Shuai Xue (2):
PCI/AER: run recovery on device that detected the error
PCI/AER: report fatal errors of RCiEP and EP if link recoverd
drivers/pci/pci.h | 3 ++-
drivers/pci/pcie/aer.c | 50 ++++++++++++++++++++++++++++++++++++++++++
drivers/pci/pcie/dpc.c | 30 ++++++++++++++++++++-----
drivers/pci/pcie/edr.c | 35 +++++++++++++++--------------
drivers/pci/pcie/err.c | 6 +++++
5 files changed, 100 insertions(+), 24 deletions(-)
--
2.39.3
next reply other threads:[~2024-11-06 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 9:03 Shuai Xue [this message]
2024-11-06 9:03 ` [RFC PATCH v1 1/2] PCI/AER: run recovery on device that detected the error Shuai Xue
2024-11-06 9:03 ` [RFC PATCH v1 2/2] PCI/AER: report fatal errors of RCiEP and EP if link recoverd Shuai Xue
2024-11-06 16:02 ` Bjorn Helgaas
2024-11-07 1:24 ` Shuai Xue
2024-11-06 16:39 ` Keith Busch
2024-11-07 1:27 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106090339.24920-1-xueshuai@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox