* Re: [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics
[not found] <20241107020555.321245-1-sanman.p211993@gmail.com>
@ 2024-11-07 11:23 ` Leon Romanovsky
0 siblings, 0 replies; only message in thread
From: Leon Romanovsky @ 2024-11-07 11:23 UTC (permalink / raw)
To: Sanman Pradhan
Cc: netdev, alexanderduyck, kuba, kernel-team, davem, edumazet,
pabeni, horms, corbet, mohsin.bashr, sanmanpradhan, andrew+netdev,
vadim.fedorenko, jdamato, sdf, linux-doc, linux-kernel,
Bjorn Helgaas, linux-pci
On Wed, Nov 06, 2024 at 06:05:55PM -0800, Sanman Pradhan wrote:
> Add PCIe hardware statistics support to the fbnic driver. These stats
> provide insight into PCIe transaction performance and error conditions.
>
> Which includes, read/write and completion TLP counts and DWORD counts and
> debug counters for tag, completion credit and NP credit exhaustion
>
> The stats are exposed via ethtool and can be used to monitor PCIe
> performance and debug PCIe issues.
>
> Signed-off-by: Sanman Pradhan <sanman.p211993@gmail.com>
> ---
> v1:
> - https://patchwork.kernel.org/project/netdevbpf/patch/20241106002625.1857904-1-sanman.p211993@gmail.com/
> - Removed unnecessary code blocks
> - Rephrased the commit message
> ---
> .../device_drivers/ethernet/meta/fbnic.rst | 27 +++++
> drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 39 ++++++
> .../net/ethernet/meta/fbnic/fbnic_ethtool.c | 77 +++++++++++-
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.c | 114 ++++++++++++++++++
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.h | 12 ++
> .../net/ethernet/meta/fbnic/fbnic_netdev.c | 3 +
> drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 2 +
> 7 files changed, 272 insertions(+), 2 deletions(-)
You completely ignored discussion and participants in v1 about
providing general solution which is applicable to all PCI devices
in the world.
Thanks
^ permalink raw reply [flat|nested] only message in thread