Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Szymon Durawa <szymon.durawa@linux.intel.com>
To: helgaas@kernel.org
Cc: Szymon Durawa <szymon.durawa@linux.intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Lukas Wunner <lukas@wunner.de>,
	linux-pci@vger.kernel.org,
	Nirmal Patel <nirmal.patel@linux.intel.com>,
	Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Subject: [PATCH v3 8/8] PCI: vmd: Add workaround for bus number hardwired to fixed non-zero value
Date: Fri, 22 Nov 2024 09:52:15 +0100	[thread overview]
Message-ID: <20241122085215.424736-9-szymon.durawa@linux.intel.com> (raw)
In-Reply-To: <20241122085215.424736-1-szymon.durawa@linux.intel.com>

VMD BUS1 rootbus primary number is 0x80 and pci_scan_bridge_extend()
detects that primary bus number doesn't match the bus it's sitting on.
As a result primary  rootbus number is deconfigured in the first pass
of pci_scan_bridge() to be re-assigned to 0x0 in the second pass.

To avoid bus number reconfiguration, BUS1 number has to be the same
as BUS1 primary number.

Suggested-by: Nirmal Patel <nirmal.patel@linux.intel.com>
Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Signed-off-by: Szymon Durawa <szymon.durawa@linux.intel.com>
---
 drivers/pci/controller/vmd.c | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 6cd14c28fd4e..3b74cb8dd023 100755
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -421,8 +421,22 @@ static void vmd_remove_irq_domain(struct vmd_dev *vmd)
 static void __iomem *vmd_cfg_addr(struct vmd_dev *vmd, struct pci_bus *bus,
 				  unsigned int devfn, int reg, int len)
 {
-	unsigned int busnr_ecam = bus->number - vmd->busn_start[VMD_BUS_0];
-	u32 offset = PCIE_ECAM_OFFSET(busnr_ecam, devfn, reg);
+	unsigned char bus_number;
+	unsigned int busnr_ecam;
+	u32 offset;
+
+	/*
+	 * VMD workaraund: for BUS1, bus->number is set to VMD_PRIMARY_BUS1
+	 * (see comment under vmd_create_bus() for BUS1) but original value
+	 * is 225 which is stored in vmd->busn_start[VMD_BUS_1].
+	 */
+	if (vmd->bus1_rootbus && bus->number == VMD_PRIMARY_BUS1)
+		bus_number = vmd->busn_start[VMD_BUS_1];
+	else
+		bus_number = bus->number;
+
+	busnr_ecam = bus_number - vmd->busn_start[VMD_BUS_0];
+	offset = PCIE_ECAM_OFFSET(busnr_ecam, devfn, reg);
 
 	if (offset + len >= resource_size(&vmd->dev->resource[VMD_CFGBAR]))
 		return NULL;
@@ -1170,6 +1184,18 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
 		 */
 		vmd->bus[VMD_BUS_1]->primary = VMD_PRIMARY_BUS1;
 
+		/*
+		 * This is a workaround for pci_scan_bridge_extend() code.
+		 * It detects that non-zero (0x80) primary bus number doesn't
+		 * match the bus it's sitting on. As a result rootbus number is
+		 * deconfigured in the first pass of pci_scan_bridge() to be
+		 * re-assigned to 0x0 in the second pass.
+		 * Update vmd->bus[VMD_BUS_1]->number and
+		 * vmd->bus[VMD_BUS_1]->primary to the same value, which
+		 * bypasses bus number reconfiguration.
+		 */
+		vmd->bus[VMD_BUS_1]->number = VMD_PRIMARY_BUS1;
+
 		WARN(sysfs_create_link(&vmd->dev->dev.kobj,
 				       &vmd->bus[VMD_BUS_1]->dev.kobj,
 				       "domain1"),
-- 
2.39.3


  parent reply	other threads:[~2024-11-22  7:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22  8:52 [PATCH v3 0/8] VMD add second rootbus support Szymon Durawa
2024-11-22  8:52 ` [PATCH v3 1/8] PCI: vmd: Add vmd_bus_enumeration() Szymon Durawa
2024-11-22  8:52 ` [PATCH v3 2/8] PCI: vmd: Add vmd_configure_cfgbar() Szymon Durawa
2024-11-22  8:52 ` [PATCH v3 3/8] PCI: vmd: Add vmd_configure_membar() and vmd_configure_membar1_membar2() Szymon Durawa
2024-11-22  8:52 ` [PATCH v3 4/8] PCI: vmd: Add vmd_create_bus() Szymon Durawa
2024-11-22  8:52 ` [PATCH v3 5/8] PCI: vmd: Replace hardcoded values with enum and defines Szymon Durawa
2025-05-05 17:33   ` Bjorn Helgaas
2024-11-22  8:52 ` [PATCH v3 6/8] PCI: vmd: Convert bus and busn_start to an array Szymon Durawa
2024-11-22  8:52 ` [PATCH v3 7/8] PCI: vmd: Add support for second rootbus under VMD Szymon Durawa
2025-05-03 13:20   ` Manivannan Sadhasivam
2025-05-05 17:31   ` Bjorn Helgaas
2024-11-22  8:52 ` Szymon Durawa [this message]
2025-05-05 17:31   ` [PATCH v3 8/8] PCI: vmd: Add workaround for bus number hardwired to fixed non-zero value Bjorn Helgaas
2025-01-27 20:59 ` [PATCH v3 0/8] VMD add second rootbus support Durawa, Szymon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241122085215.424736-9-szymon.durawa@linux.intel.com \
    --to=szymon.durawa@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=nirmal.patel@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox