Re: [PATCH v3 0/8] VMD add second rootbus support

["Durawa, Szymon" <szymon.durawa@linux.intel.com>]

On 11/22/2024 9:52 AM, Szymon Durawa wrote:
> This patch series implements second rootbus support inside Intel VMD module.
> Current implementation allows VMD to take ownership of devices only on first
> bus (Rootbus0). Starting from Intel Arrow Lake, VMD exposes second bus
> (Rootbus1) to allow VMD to own devices on this bus as well. VMD MMIO BARs
> (CFGBAR. MEMBAR1 and MEMBAR2) are now shared between Rootbus0 and Rootbus1.
> Reconfiguration of 3 MMIO BARs is required by resizing current MMIO BARs ranges.
> It allows to find/register VMD Rootbus1 and discovers devices or root
> ports under it.
>
> Patches 1 to 6 introduce code refactoring without functional changes.
> Patch 7 implements VMD Rootbus1 support and patch 8 provides workaround for
> rootbus number hardwired to fixed non-zero value. Patch 8 is necessary for
> correct enumeration attached devices under VMD Rootbus1. Without it user cannot
> access those devices as they are not visible in the system, only drives under
> VMD Rootbus0 are available to the user.
>
> Changes from v1:
> - splitting series into more commits, requested by Bjorn
> - adding helper functions, suggested by Bjorn
> - minor typos and unclear wording updated, suggested by Bjorn
>
> Changes from v2:
> - wording update in commit logs, suggested by Bjorn
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Lukas Wunner <lukas@wunner.de>
> Cc: linux-pci@vger.kernel.org
> Suggested-by: Nirmal Patel <nirmal.patel@linux.intel.com>
> Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> Signed-off-by: Szymon Durawa <szymon.durawa@linux.intel.com>
>
> Szymon Durawa (8):
>    PCI: vmd: Add vmd_bus_enumeration()
>    PCI: vmd: Add vmd_configure_cfgbar()
>    PCI: vmd: Add vmd_configure_membar() and
>      vmd_configure_membar1_membar2()
>    PCI: vmd: Add vmd_create_bus()
>    PCI: vmd: Replace hardcoded values with enum and defines
>    PCI: vmd: Convert bus and busn_start to an array
>    PCI: vmd: Add support for second rootbus under VMD
>    PCI: vmd: Add workaround for bus number hardwired to fixed non-zero
>      value
>
>   drivers/pci/controller/vmd.c | 470 +++++++++++++++++++++++++++--------
>   1 file changed, 360 insertions(+), 110 deletions(-)
>   mode change 100644 => 100755 drivers/pci/controller/vmd.c

Hello Bjorn,

Gentle ping. I addressed all of your previous comments, please take a 
look at v3 patch.

Thanks,

Szymon