public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Frank Li" <Frank.Li@nxp.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Karthikeyan Mitran" <m.karthikeyan@mobiveil.co.in>,
	"Hou Zhiqiang" <Zhiqiang.Hou@nxp.com>, Frank <Li@nxp.com>,
	"open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS"
	<linux-pci@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: PCI: mobiveil: convert mobiveil-pcie.txt to yaml format
Date: Tue, 10 Dec 2024 11:07:42 -0600	[thread overview]
Message-ID: <20241210170742.GA3246646@bhelgaas> (raw)
In-Reply-To: <4v7ma5bkczhrc4syzahsr2kxg5ulxgmnsfktdrlztjobpdkcra@yppf5e4s5vay>

On Tue, Dec 10, 2024 at 09:42:31AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Dec 09, 2024 at 05:51:21PM -0600, Bjorn Helgaas wrote:
> > On Fri, Dec 06, 2024 at 05:25:27PM -0500, Frank Li wrote:
> > > Convert device tree binding doc mobiveil-pcie.txt to yaml format. Merge
> > > layerscape-pcie-gen4.txt into this file.
> > > 
> > > Additional change:
> > > - interrupt-names: "aer", "pme", "intr", which align order in examples.
> > > - reg-names: csr_axi_slave, config_axi_slave, which align existed dts file.
> > 
> > Is there any way to split this into two patches:
> > 
> >   - Convert to yaml and update MAINTAINERS
> >   - Update interrupt-names, reg-names
> > 
> > It's hard to review the interrupt-names, reg-names when they're mixed
> > in with the yaml conversion.
> 
> The conversion should result in a correct binding, so if original
> binding had some issues (and TXT bindings often have: missing or
> stale/not-udpated properties), then we expect any fixes in the same
> commit.  New things, not supported by existing in-kernel upstream users
> or bindings, should be of course in separate patch.

Maybe they could be added to the original TXT binding first in one
patch, and then converted to yaml in a second patch?

  reply	other threads:[~2024-12-10 17:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 22:25 [PATCH v2 1/1] dt-bindings: PCI: mobiveil: convert mobiveil-pcie.txt to yaml format Frank Li
2024-12-09 23:51 ` Bjorn Helgaas
2024-12-10  8:42   ` Krzysztof Kozlowski
2024-12-10 17:07     ` Bjorn Helgaas [this message]
2024-12-11  8:12       ` Krzysztof Kozlowski
2024-12-10  8:52 ` Krzysztof Kozlowski
2024-12-10 17:10   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210170742.GA3246646@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=Li@nxp.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.karthikeyan@mobiveil.co.in \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox