Re: [PATCH v2 1/1] dt-bindings: PCI: mobiveil: convert mobiveil-pcie.txt to yaml format

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/12/2024 18:07, Bjorn Helgaas wrote:
> On Tue, Dec 10, 2024 at 09:42:31AM +0100, Krzysztof Kozlowski wrote:
>> On Mon, Dec 09, 2024 at 05:51:21PM -0600, Bjorn Helgaas wrote:
>>> On Fri, Dec 06, 2024 at 05:25:27PM -0500, Frank Li wrote:
>>>> Convert device tree binding doc mobiveil-pcie.txt to yaml format. Merge
>>>> layerscape-pcie-gen4.txt into this file.
>>>>
>>>> Additional change:
>>>> - interrupt-names: "aer", "pme", "intr", which align order in examples.
>>>> - reg-names: csr_axi_slave, config_axi_slave, which align existed dts file.
>>>
>>> Is there any way to split this into two patches:
>>>
>>>   - Convert to yaml and update MAINTAINERS
>>>   - Update interrupt-names, reg-names
>>>
>>> It's hard to review the interrupt-names, reg-names when they're mixed
>>> in with the yaml conversion.
>>
>> The conversion should result in a correct binding, so if original
>> binding had some issues (and TXT bindings often have: missing or
>> stale/not-udpated properties), then we expect any fixes in the same
>> commit.  New things, not supported by existing in-kernel upstream users
>> or bindings, should be of course in separate patch.
> 
> Maybe they could be added to the original TXT binding first in one
> patch, and then converted to yaml in a second patch?


This would solve one thing and cause another issues: you add lines in
one commit which are immediately removed in the next commit, plus we
don't want any changes in TXT because absolute lack of means for
verification/testing.


Best regards,
Krzysztof