public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Takashi Iwai" <tiwai@suse.de>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Kuppuswamy Sathyanarayanan"
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"Keith Busch" <keith.busch@intel.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/DPC: Yet another quirk for PIO log size on Intel Raptor Lake-P
Date: Sun, 5 Jan 2025 10:25:20 +0200	[thread overview]
Message-ID: <20250105082520.GT3713119@black.fi.intel.com> (raw)
In-Reply-To: <20250103225315.GA12322@bhelgaas>

Hi,

On Fri, Jan 03, 2025 at 04:53:15PM -0600, Bjorn Helgaas wrote:
> On Thu, Jan 02, 2025 at 05:43:13PM +0100, Takashi Iwai wrote:
> > There is yet another PCI entry for Intel Raptor Lake-P that shows the
> >   error "DPC: RP PIO log size 0 is invalid":
> >   0000:00:07.0 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #0 [8086:a76e]
> >   0000:00:07.2 PCI bridge [0604]: Intel Corporation Raptor Lake-P Thunderbolt 4 PCI Express Root Port #2 [8086:a72f]
> > 
> > Add the corresponding quirk entry for 8086:a72f.
> > 
> > Note that the one for 8086:a76e has been already added by the commit
> > 627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root
> > Ports").
> 
> Intel folks, what's the long-term resolution of this?  I'm kind of
> tired of adding quirks like this.  So far we have these (not including
> the current patch), dating back to Aug 2022:
> 
>   627c6db20703 ("PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports")
>   3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice Lake Root Ports")
>   5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root Ports")
> 
> I *thought* this problem was caused by BIOS defects that were supposed
> to be fixed, but nothing seems to be happening.

As far as I know it should be fixed already. I just checked my MTLP and PTL
systems (both with integrated TBT PCIe root ports) and I don't see the
message anymore. I don't have RPL system though. This is on reference
hardware and BIOS so it is possible that the fix has not been taken into
the OEM BIOS.

  reply	other threads:[~2025-01-05  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 16:43 [PATCH] PCI/DPC: Yet another quirk for PIO log size on Intel Raptor Lake-P Takashi Iwai
2025-01-03 22:53 ` Bjorn Helgaas
2025-01-05  8:25   ` Mika Westerberg [this message]
2025-01-10  9:45     ` Takashi Iwai
2025-01-14 22:45 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250105082520.GT3713119@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox