From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Hans Zhang <18255117159@163.com>,
kishon@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rockswang7@gmail.com
Subject: Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size
Date: Fri, 17 Jan 2025 17:49:18 +0900 [thread overview]
Message-ID: <20250117084918.GA1752843@rocinante> (raw)
In-Reply-To: <Z4jTeNjl7ddfcQl1@ryzen>
Hello,
> > Since you have already applied this series, with my comment fixed up,
> > could your perhaps add the following (or similar) to the commit message
> > in patch 2/2:
> >
> >
> > "
> > By changing the type to resource_size_t, which is a typedef to phys_addr_t,
> > which can be 64-bit in certain configurations (e.g. X86_PAE selects
> > PHYS_ADDR_T_64BIT), even when the compiler is 32-bit. Thus, we also need to
> > change the division to do_div(), to properly perform a 64-bit division when
> > the compiler is 32-bit.
> > "
>
> s/do_div()/div_u64()/
Will do. Sounds good!
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-01-17 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 9:45 [v11 0/2] misc: pci_endpoint_test: Fix overflow of bar_size Hans Zhang
2025-01-09 9:45 ` [v11 1/2] misc: pci_endpoint_test: Remove the "remainder" code Hans Zhang
2025-01-15 16:58 ` Manivannan Sadhasivam
2025-01-09 9:45 ` [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size Hans Zhang
2025-01-15 16:58 ` Manivannan Sadhasivam
2025-01-15 17:05 ` Niklas Cassel
2025-01-16 2:03 ` Krzysztof Wilczyński
2025-01-16 9:36 ` Niklas Cassel
2025-01-16 9:38 ` Niklas Cassel
2025-01-17 8:49 ` Krzysztof Wilczyński [this message]
2025-01-21 17:46 ` Jon Hunter
2025-01-21 20:23 ` Bjorn Helgaas
2025-01-21 20:31 ` Niklas Cassel
2025-01-22 6:03 ` Jon Hunter
2025-01-22 10:07 ` Niklas Cassel
2025-01-22 10:26 ` Arnd Bergmann
2025-01-22 11:18 ` Jon Hunter
2025-01-23 8:10 ` Niklas Cassel
2025-01-15 14:02 ` [v11 0/2] " Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117084918.GA1752843@rocinante \
--to=kw@linux.com \
--cc=18255117159@163.com \
--cc=arnd@arndb.de \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rockswang7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox