From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Hans Zhang <18255117159@163.com>,
kw@linux.com, kishon@kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, rockswang7@gmail.com
Subject: Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size
Date: Wed, 15 Jan 2025 18:05:45 +0100 [thread overview]
Message-ID: <Z4fq6XU650iOsFZe@ryzen> (raw)
In-Reply-To: <20250115165842.p7vo24zwjvej2tbc@thinkpad>
Hello Hans,
On Wed, Jan 15, 2025 at 10:28:42PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Jan 09, 2025 at 05:45:56PM +0800, Hans Zhang wrote:
> > With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED".
> >
> > The return value of the `pci_resource_len` interface is not an integer.
> > Using `pcitest` with an 8GB BAR2, the bar_size of integer type will
> > overflow.
> >
> > Change the data type of bar_size from integer to resource_size_t, to fix
> > the above issue.
> >
> > Signed-off-by: Hans Zhang <18255117159@163.com>
> > Suggested-by: Niklas Cassel <cassel@kernel.org>
I intended to stay silent, but considering that Mani gave additional
feedback:
- The Suggested-by tag should be in patch 1/2, not 2/2 :)
(Patch 2/2 was 100% you.)
- No need to keep the change log all the way back since V1, usually
people just keep the change log since the last revision.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-01-15 17:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 9:45 [v11 0/2] misc: pci_endpoint_test: Fix overflow of bar_size Hans Zhang
2025-01-09 9:45 ` [v11 1/2] misc: pci_endpoint_test: Remove the "remainder" code Hans Zhang
2025-01-15 16:58 ` Manivannan Sadhasivam
2025-01-09 9:45 ` [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size Hans Zhang
2025-01-15 16:58 ` Manivannan Sadhasivam
2025-01-15 17:05 ` Niklas Cassel [this message]
2025-01-16 2:03 ` Krzysztof Wilczyński
2025-01-16 9:36 ` Niklas Cassel
2025-01-16 9:38 ` Niklas Cassel
2025-01-17 8:49 ` Krzysztof Wilczyński
2025-01-21 17:46 ` Jon Hunter
2025-01-21 20:23 ` Bjorn Helgaas
2025-01-21 20:31 ` Niklas Cassel
2025-01-22 6:03 ` Jon Hunter
2025-01-22 10:07 ` Niklas Cassel
2025-01-22 10:26 ` Arnd Bergmann
2025-01-22 11:18 ` Jon Hunter
2025-01-23 8:10 ` Niklas Cassel
2025-01-15 14:02 ` [v11 0/2] " Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4fq6XU650iOsFZe@ryzen \
--to=cassel@kernel.org \
--cc=18255117159@163.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rockswang7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox