Re: [PATCH v5] PCI: dwc: Wait for link up only if link is started

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Fri, Feb 14, 2025 at 10:18:27AM +0100, Johan Hovold wrote:
> On Fri, Feb 14, 2025 at 02:45:03PM +0530, Ajay Agarwal wrote:
> 
> > Restarting this discussion for skipping the 1 sec of wait time if a
> > certain platform does not necessarily wish or expect to bring the link
> > up during probe time. I discussed with William and we think that a
> > module parameter can be added which if true, would lead to the skipping
> > of the wait time. By default, this parameter would be false, thereby
> > ensuring that the current behaviour to wait for the link is maintained.
> > 
> > Please let me know if this is worth exploring.
> 
> No, module parameters are a thing of the past (except possibly in vendor
> kernels). The default behaviour should just work.
> 

+1

Btw, you need to come up with a valid argument for not enabling the link during
probe. Also, not waiting for link during probe is also not going to work across
all platforms where the controller is used, unless your hardware supports
hotplug or LINK_UP IRQ.

- Mani

-- 
மணிவண்ணன் சதாசிவம்