* [PATCH] PCI: Log debug messages about reset method
@ 2025-03-03 20:42 Bjorn Helgaas
2025-03-03 21:08 ` Dave Jiang
2025-03-10 18:43 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2025-03-03 20:42 UTC (permalink / raw)
To: linux-pci
Cc: Alex Williamson, Ilpo Järvinen, Keith Busch, Todd Kjos,
Dan Williams, Dave Jiang, linux-kernel, Bjorn Helgaas
From: Bjorn Helgaas <bhelgaas@google.com>
Log pci_dbg() messages about the reset methods we attempt and any errors
(-ENOTTY means "try the next method").
Set CONFIG_DYNAMIC_DEBUG=y and enable by booting with
dyndbg="file drivers/pci/* +p" or enable at runtime:
# echo "file drivers/pci/* +p" > /sys/kernel/debug/dynamic_debug/control
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pci.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 869d204a70a3..3d13bb8e5c53 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -5230,6 +5230,7 @@ const struct pci_reset_fn_method pci_reset_fn_methods[] = {
int __pci_reset_function_locked(struct pci_dev *dev)
{
int i, m, rc;
+ const struct pci_reset_fn_method *method;
might_sleep();
@@ -5246,9 +5247,13 @@ int __pci_reset_function_locked(struct pci_dev *dev)
if (!m)
return -ENOTTY;
- rc = pci_reset_fn_methods[m].reset_fn(dev, PCI_RESET_DO_RESET);
+ method = &pci_reset_fn_methods[m];
+ pci_dbg(dev, "reset via %s\n", method->name);
+ rc = method->reset_fn(dev, PCI_RESET_DO_RESET);
if (!rc)
return 0;
+
+ pci_dbg(dev, "%s failed with %d\n", method->name, rc);
if (rc != -ENOTTY)
return rc;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: Log debug messages about reset method
2025-03-03 20:42 [PATCH] PCI: Log debug messages about reset method Bjorn Helgaas
@ 2025-03-03 21:08 ` Dave Jiang
2025-03-10 18:43 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2025-03-03 21:08 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci
Cc: Alex Williamson, Ilpo Järvinen, Keith Busch, Todd Kjos,
Dan Williams, linux-kernel, Bjorn Helgaas
On 3/3/25 1:42 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Log pci_dbg() messages about the reset methods we attempt and any errors
> (-ENOTTY means "try the next method").
>
> Set CONFIG_DYNAMIC_DEBUG=y and enable by booting with
> dyndbg="file drivers/pci/* +p" or enable at runtime:
>
> # echo "file drivers/pci/* +p" > /sys/kernel/debug/dynamic_debug/control
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/pci/pci.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..3d13bb8e5c53 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -5230,6 +5230,7 @@ const struct pci_reset_fn_method pci_reset_fn_methods[] = {
> int __pci_reset_function_locked(struct pci_dev *dev)
> {
> int i, m, rc;
> + const struct pci_reset_fn_method *method;
>
> might_sleep();
>
> @@ -5246,9 +5247,13 @@ int __pci_reset_function_locked(struct pci_dev *dev)
> if (!m)
> return -ENOTTY;
>
> - rc = pci_reset_fn_methods[m].reset_fn(dev, PCI_RESET_DO_RESET);
> + method = &pci_reset_fn_methods[m];
> + pci_dbg(dev, "reset via %s\n", method->name);
> + rc = method->reset_fn(dev, PCI_RESET_DO_RESET);
> if (!rc)
> return 0;
> +
> + pci_dbg(dev, "%s failed with %d\n", method->name, rc);
> if (rc != -ENOTTY)
> return rc;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: Log debug messages about reset method
2025-03-03 20:42 [PATCH] PCI: Log debug messages about reset method Bjorn Helgaas
2025-03-03 21:08 ` Dave Jiang
@ 2025-03-10 18:43 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2025-03-10 18:43 UTC (permalink / raw)
To: linux-pci
Cc: Alex Williamson, Ilpo Järvinen, Keith Busch, Todd Kjos,
Dan Williams, Dave Jiang, linux-kernel, Bjorn Helgaas
On Mon, Mar 03, 2025 at 02:42:20PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Log pci_dbg() messages about the reset methods we attempt and any errors
> (-ENOTTY means "try the next method").
>
> Set CONFIG_DYNAMIC_DEBUG=y and enable by booting with
> dyndbg="file drivers/pci/* +p" or enable at runtime:
>
> # echo "file drivers/pci/* +p" > /sys/kernel/debug/dynamic_debug/control
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Applied to pci/reset for v6.15.
> ---
> drivers/pci/pci.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..3d13bb8e5c53 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -5230,6 +5230,7 @@ const struct pci_reset_fn_method pci_reset_fn_methods[] = {
> int __pci_reset_function_locked(struct pci_dev *dev)
> {
> int i, m, rc;
> + const struct pci_reset_fn_method *method;
>
> might_sleep();
>
> @@ -5246,9 +5247,13 @@ int __pci_reset_function_locked(struct pci_dev *dev)
> if (!m)
> return -ENOTTY;
>
> - rc = pci_reset_fn_methods[m].reset_fn(dev, PCI_RESET_DO_RESET);
> + method = &pci_reset_fn_methods[m];
> + pci_dbg(dev, "reset via %s\n", method->name);
> + rc = method->reset_fn(dev, PCI_RESET_DO_RESET);
> if (!rc)
> return 0;
> +
> + pci_dbg(dev, "%s failed with %d\n", method->name, rc);
> if (rc != -ENOTTY)
> return rc;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-10 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-03 20:42 [PATCH] PCI: Log debug messages about reset method Bjorn Helgaas
2025-03-03 21:08 ` Dave Jiang
2025-03-10 18:43 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox