From: Bjorn Helgaas <helgaas@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Frank Li <Frank.Li@nxp.com>,
oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [pci:controller/dwc-cpu-addr-fixup 6/14] drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer
Date: Fri, 21 Mar 2025 13:00:04 -0500 [thread overview]
Message-ID: <20250321180004.GA1137242@bhelgaas> (raw)
In-Reply-To: <202503210649.lau9JEgG-lkp@intel.com>
On Fri, Mar 21, 2025 at 06:56:55AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc-cpu-addr-fixup
> head: 94d1d26431c0e4c845e9e9ee5f23bcc9a53d95ec
> commit: c1154a3218325a03cd07df51a7076a353a723589 [6/14] PCI: dwc: Add dw_pcie_parent_bus_offset() checking and debug
> config: alpha-randconfig-r121-20250321 (https://download.01.org/0day-ci/archive/20250321/202503210649.lau9JEgG-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 12.4.0
> reproduce: (https://download.01.org/0day-ci/archive/20250321/202503210649.lau9JEgG-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503210649.lau9JEgG-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer
> vim +1130 drivers/pci/controller/dwc/pcie-designware.c
>
> 1109
> 1110 resource_size_t dw_pcie_parent_bus_offset(struct dw_pcie *pci,
> 1111 const char *reg_name,
> 1112 resource_size_t cpu_phy_addr)
> 1113 {
> > 1130 fixup = pci->ops ? pci->ops->cpu_addr_fixup : 0;
Replaced with
fixup = pci->ops ? pci->ops->cpu_addr_fixup : NULL;
prev parent reply other threads:[~2025-03-21 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 22:56 [pci:controller/dwc-cpu-addr-fixup 6/14] drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer kernel test robot
2025-03-21 18:00 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321180004.GA1137242@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=ioana.ciornei@nxp.com \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox