[pci:controller/dwc-cpu-addr-fixup 6/14] drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer

[pci:controller/dwc-cpu-addr-fixup 6/14] drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc-cpu-addr-fixup
head:   94d1d26431c0e4c845e9e9ee5f23bcc9a53d95ec
commit: c1154a3218325a03cd07df51a7076a353a723589 [6/14] PCI: dwc: Add dw_pcie_parent_bus_offset() checking and debug
config: alpha-randconfig-r121-20250321 (https://download.01.org/0day-ci/archive/20250321/202503210649.lau9JEgG-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.4.0
reproduce: (https://download.01.org/0day-ci/archive/20250321/202503210649.lau9JEgG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503210649.lau9JEgG-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer
   drivers/pci/controller/dwc/pcie-designware.c: note: in included file (through arch/alpha/include/asm/core_tsunami.h, arch/alpha/include/asm/io.h, include/linux/scatterlist.h, ...):
   arch/alpha/include/asm/io_trivial.h:70:16: sparse: sparse: undefined identifier '__kernel_ldwu'
   arch/alpha/include/asm/io_trivial.h:64:16: sparse: sparse: undefined identifier '__kernel_ldbu'
   arch/alpha/include/asm/io_trivial.h:82:9: sparse: sparse: undefined identifier '__kernel_stw'
   arch/alpha/include/asm/io_trivial.h:76:9: sparse: sparse: undefined identifier '__kernel_stb'

vim +1130 drivers/pci/controller/dwc/pcie-designware.c

  1109	
  1110	resource_size_t dw_pcie_parent_bus_offset(struct dw_pcie *pci,
  1111						  const char *reg_name,
  1112						  resource_size_t cpu_phy_addr)
  1113	{
  1114		struct device *dev = pci->dev;
  1115		struct device_node *np = dev->of_node;
  1116		int index;
  1117		u64 reg_addr, fixup_addr;
  1118		u64 (*fixup)(struct dw_pcie *pcie, u64 cpu_addr);
  1119	
  1120		/* Look up reg_name address on parent bus */
  1121		index = of_property_match_string(np, "reg-names", reg_name);
  1122	
  1123		if (index < 0) {
  1124			dev_err(dev, "No %s in devicetree \"reg\" property\n", reg_name);
  1125			return 0;
  1126		}
  1127	
  1128		of_property_read_reg(np, index, &reg_addr, NULL);
  1129	
> 1130		fixup = pci->ops ? pci->ops->cpu_addr_fixup : 0;

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [pci:controller/dwc-cpu-addr-fixup 6/14] drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer

[Bjorn Helgaas]

On Fri, Mar 21, 2025 at 06:56:55AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc-cpu-addr-fixup
> head:   94d1d26431c0e4c845e9e9ee5f23bcc9a53d95ec
> commit: c1154a3218325a03cd07df51a7076a353a723589 [6/14] PCI: dwc: Add dw_pcie_parent_bus_offset() checking and debug
> config: alpha-randconfig-r121-20250321 (https://download.01.org/0day-ci/archive/20250321/202503210649.lau9JEgG-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 12.4.0
> reproduce: (https://download.01.org/0day-ci/archive/20250321/202503210649.lau9JEgG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503210649.lau9JEgG-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/pci/controller/dwc/pcie-designware.c:1130:55: sparse: sparse: Using plain integer as NULL pointer

> vim +1130 drivers/pci/controller/dwc/pcie-designware.c
> 
>   1109	
>   1110	resource_size_t dw_pcie_parent_bus_offset(struct dw_pcie *pci,
>   1111						  const char *reg_name,
>   1112						  resource_size_t cpu_phy_addr)
>   1113	{

> > 1130		fixup = pci->ops ? pci->ops->cpu_addr_fixup : 0;

Replaced with

    fixup = pci->ops ? pci->ops->cpu_addr_fixup : NULL;