* [PATCH 1/1] PCI: Remove pci_printk()
@ 2025-04-07 10:12 Ilpo Järvinen
2025-05-14 16:24 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2025-04-07 10:12 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci, linux-kernel; +Cc: Ilpo Järvinen
include/linux/pci.h provides low-level pci_printk() interface that is
not used since the commits fab874e12593 ("PCI/AER: Descope pci_printk()
to aer_printk()") and 588021b28642 ("PCI: shpchp: Remove 'shpchp_debug'
module parameter"). PCI logging should not use pci_printk() but pci_*()
wrappers that follow the usual logging wrapper patterns.
Remove pci_printk().
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
include/linux/pci.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 0e8e3fd77e96..e293ad5d840d 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2694,9 +2694,6 @@ void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type);
#include <linux/dma-mapping.h>
-#define pci_printk(level, pdev, fmt, arg...) \
- dev_printk(level, &(pdev)->dev, fmt, ##arg)
-
#define pci_emerg(pdev, fmt, arg...) dev_emerg(&(pdev)->dev, fmt, ##arg)
#define pci_alert(pdev, fmt, arg...) dev_alert(&(pdev)->dev, fmt, ##arg)
#define pci_crit(pdev, fmt, arg...) dev_crit(&(pdev)->dev, fmt, ##arg)
base-commit: 7d06015d936c861160803e020f68f413b5c3cd9d
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] PCI: Remove pci_printk()
2025-04-07 10:12 [PATCH 1/1] PCI: Remove pci_printk() Ilpo Järvinen
@ 2025-05-14 16:24 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2025-05-14 16:24 UTC (permalink / raw)
To: Bjorn Helgaas, Ilpo Järvinen, linux-pci, linux-kernel
Hello,
> include/linux/pci.h provides low-level pci_printk() interface that is
> not used since the commits fab874e12593 ("PCI/AER: Descope pci_printk()
> to aer_printk()") and 588021b28642 ("PCI: shpchp: Remove 'shpchp_debug'
> module parameter"). PCI logging should not use pci_printk() but pci_*()
> wrappers that follow the usual logging wrapper patterns.
>
> Remove pci_printk().
>
> [...]
Applied to misc, thank you!
[1/1] PCI: Remove pci_printk()
https://git.kernel.org/pci/pci/c/56d305b24d64
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-14 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 10:12 [PATCH 1/1] PCI: Remove pci_printk() Ilpo Järvinen
2025-05-14 16:24 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox