[PATCH 1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()

[PATCH 1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()

[Ilpo Järvinen]

No need to split the line in __pci_setup_bridge() as it is way shorter
than the limit.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/pci/setup-bus.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 54d6f4fa3ce1..45bf0ddff118 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -772,8 +772,7 @@ static void __pci_setup_bridge(struct pci_bus *bus, unsigned long type)
 {
 	struct pci_dev *bridge = bus->self;
 
-	pci_info(bridge, "PCI bridge to %pR\n",
-		 &bus->busn_res);
+	pci_info(bridge, "PCI bridge to %pR\n", &bus->busn_res);
 
 	if (type & IORESOURCE_IO)
 		pci_setup_bridge_io(bridge);

base-commit: 7d06015d936c861160803e020f68f413b5c3cd9d
-- 
2.39.5

Re: [PATCH 1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()

[Krzysztof Wilczyński]

Hello,

[...]
> -	pci_info(bridge, "PCI bridge to %pR\n",
> -		 &bus->busn_res);
> +	pci_info(bridge, "PCI bridge to %pR\n", &bus->busn_res);

I don't know if there still exists such a thing as "trivial patches
maintainer" any more, so I will pull this.

I gather, it must have bothered you a bit. That said, Ilpo... your
expertise and time could have been spent differently. :)

Thank you!

	Krzysztof

Re: [PATCH 1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()

[Krzysztof Wilczyński]

Hello,

> No need to split the line in __pci_setup_bridge() as it is way shorter
> than the limit.
> 
> 

Applied to misc, thank you!

[1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()
      https://git.kernel.org/pci/pci/c/e57eb4f08f5a

	Krzysztof

Re: [PATCH 1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On Fri, 16 May 2025, Krzysztof Wilczyński wrote:

> [...]
> > -	pci_info(bridge, "PCI bridge to %pR\n",
> > -		 &bus->busn_res);
> > +	pci_info(bridge, "PCI bridge to %pR\n", &bus->busn_res);
> 
> I don't know if there still exists such a thing as "trivial patches
> maintainer" any more, so I will pull this.
> 
> I gather, it must have bothered you a bit. That said, Ilpo... your
> expertise and time could have been spent differently. :)

It doesn't take long to do patches like this and I don't search for things 
like this intentionally nor focus on them. It's just that I do encounter 
these simple ones too while I'm spending my expertise differently :-). You 
can check my track record on discovering e.g. real concurrency issues 
recently so I hope you can give a bit slack on a few trivial patches here 
and there ;-).

-- 
 i.

Re: [PATCH 1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()

[Krzysztof Wilczyński]

Hello,

[...]
> You can check my track record on discovering e.g. real concurrency issues
> recently so I hope you can give a bit slack on a few trivial patches here
> and there ;-).

We love your work!  The unparalleled attention to details, especially. :)

On the topic of trivial patches...  There has been a debate within the
community at large about trivial patches, per:

  https://lore.kernel.org/all/YIGXzB0CyRtGfqfE@zeniv-ca.linux.org.uk/t/

Lot of opinions there...  Ultimately, most of the time things are up to
the maintainers, as per usual.

Thank you again for all your work!  Much appreciated!

	Krzysztof