From: Bjorn Helgaas <helgaas@kernel.org>
To: Li Jun <lijun01@kylinos.cn>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci: Fix kernel coding style
Date: Wed, 6 Aug 2025 15:43:41 -0500 [thread overview]
Message-ID: <20250806204341.GA17141@bhelgaas> (raw)
In-Reply-To: <20250731023326.542847-1-lijun01@kylinos.cn>
On Thu, Jul 31, 2025 at 10:33:26AM +0800, Li Jun wrote:
> These changes just fix Linux Kernel Coding Style, no functuional
> improve.
>
> -Missing a blank line after declarations
> -space required after that ','
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
Applied to pci/misc for v6.18, thanks.
> ---
> drivers/pci/setup-bus.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 7853ac6999e2..119f97b96480 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -1402,6 +1402,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head)
>
> list_for_each_entry(dev, &bus->devices, bus_list) {
> struct pci_bus *b = dev->subordinate;
> +
> if (!b)
> continue;
>
> @@ -1784,6 +1785,7 @@ static void pci_bus_release_bridge_resources(struct pci_bus *bus,
>
> list_for_each_entry(dev, &bus->devices, bus_list) {
> struct pci_bus *b = dev->subordinate;
> +
> if (!b)
> continue;
>
> @@ -2136,7 +2138,7 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus,
> res = &dev->resource[PCI_BRIDGE_MEM_WINDOW];
> align = pci_resource_alignment(dev, res);
> resource_set_size(&mmio,
> - ALIGN_DOWN_IF_NONZERO(mmio_per_b,align));
> + ALIGN_DOWN_IF_NONZERO(mmio_per_b, align));
> mmio.start -= resource_size(res);
>
> res = &dev->resource[PCI_BRIDGE_PREF_MEM_WINDOW];
> --
> 2.25.1
>
prev parent reply other threads:[~2025-08-06 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 2:33 [PATCH] pci: Fix kernel coding style Li Jun
2025-08-06 20:43 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806204341.GA17141@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=lijun01@kylinos.cn \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox