* [PATCH] pci: Fix kernel coding style
@ 2025-07-31 2:33 Li Jun
2025-08-06 20:43 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Li Jun @ 2025-07-31 2:33 UTC (permalink / raw)
To: lijun01, bhelgaas, linux-pci
These changes just fix Linux Kernel Coding Style, no functuional
improve.
-Missing a blank line after declarations
-space required after that ','
Signed-off-by: Li Jun <lijun01@kylinos.cn>
---
drivers/pci/setup-bus.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 7853ac6999e2..119f97b96480 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -1402,6 +1402,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head)
list_for_each_entry(dev, &bus->devices, bus_list) {
struct pci_bus *b = dev->subordinate;
+
if (!b)
continue;
@@ -1784,6 +1785,7 @@ static void pci_bus_release_bridge_resources(struct pci_bus *bus,
list_for_each_entry(dev, &bus->devices, bus_list) {
struct pci_bus *b = dev->subordinate;
+
if (!b)
continue;
@@ -2136,7 +2138,7 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus,
res = &dev->resource[PCI_BRIDGE_MEM_WINDOW];
align = pci_resource_alignment(dev, res);
resource_set_size(&mmio,
- ALIGN_DOWN_IF_NONZERO(mmio_per_b,align));
+ ALIGN_DOWN_IF_NONZERO(mmio_per_b, align));
mmio.start -= resource_size(res);
res = &dev->resource[PCI_BRIDGE_PREF_MEM_WINDOW];
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: Fix kernel coding style
2025-07-31 2:33 [PATCH] pci: Fix kernel coding style Li Jun
@ 2025-08-06 20:43 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2025-08-06 20:43 UTC (permalink / raw)
To: Li Jun; +Cc: bhelgaas, linux-pci
On Thu, Jul 31, 2025 at 10:33:26AM +0800, Li Jun wrote:
> These changes just fix Linux Kernel Coding Style, no functuional
> improve.
>
> -Missing a blank line after declarations
> -space required after that ','
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
Applied to pci/misc for v6.18, thanks.
> ---
> drivers/pci/setup-bus.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 7853ac6999e2..119f97b96480 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -1402,6 +1402,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head)
>
> list_for_each_entry(dev, &bus->devices, bus_list) {
> struct pci_bus *b = dev->subordinate;
> +
> if (!b)
> continue;
>
> @@ -1784,6 +1785,7 @@ static void pci_bus_release_bridge_resources(struct pci_bus *bus,
>
> list_for_each_entry(dev, &bus->devices, bus_list) {
> struct pci_bus *b = dev->subordinate;
> +
> if (!b)
> continue;
>
> @@ -2136,7 +2138,7 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus,
> res = &dev->resource[PCI_BRIDGE_MEM_WINDOW];
> align = pci_resource_alignment(dev, res);
> resource_set_size(&mmio,
> - ALIGN_DOWN_IF_NONZERO(mmio_per_b,align));
> + ALIGN_DOWN_IF_NONZERO(mmio_per_b, align));
> mmio.start -= resource_size(res);
>
> res = &dev->resource[PCI_BRIDGE_PREF_MEM_WINDOW];
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-06 20:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-31 2:33 [PATCH] pci: Fix kernel coding style Li Jun
2025-08-06 20:43 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox