From: Bjorn Helgaas <helgaas@kernel.org>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>
Cc: Devendra K Verma <devendra.verma@amd.com>,
bhelgaas@google.com, mani@kernel.org, vkoul@kernel.org,
dmaengine@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com
Subject: Re: [External] : [PATCH v2 1/2] dmaengine: dw-edma: Add AMD MDB Endpoint Support
Date: Tue, 16 Sep 2025 10:05:32 -0500 [thread overview]
Message-ID: <20250916150532.GA1797586@bhelgaas> (raw)
In-Reply-To: <17dbecb3-6261-4df4-a2ee-e55a398c732b@oracle.com>
On Tue, Sep 16, 2025 at 04:25:49PM +0530, ALOK TIWARI wrote:
>
>
> On 9/16/2025 4:13 PM, Devendra K Verma wrote:
> > + /*
> > + * Synopsys and AMD (Xilinx) use the same VSEC ID for the purpose
> > + * of map, channel counts, etc.
> > + */
> > + if (vendor != PCI_VENDOR_ID_SYNOPSYS ||
> > + vendor != PCI_VENDOR_ID_XILINX)
> > + return;
>
> if, vendor == PCI_VENDOR_ID_XILINX condition will true
>
> should not be if (vendor != PCI_VENDOR_ID_SYNOPSYS && vendor !=
> PCI_VENDOR_ID_XILINX) ?
Good catch, I mistakenly said this part was correct, but you're right;
it's obviously broken.
The alternate structure I suggested would avoid this problem.
> > +
> > + cap = DW_PCIE_VSEC_DMA_ID;
> > + if (vendor == PCI_VENDOR_ID_XILINX)
> > + cap = DW_PCIE_XILINX_MDB_VSEC_ID;
> > +
> > + vsec = pci_find_vsec_capability(pdev, vendor, cap);
> > if (!vsec)
>
>
> Thanks,
> Alok
next prev parent reply other threads:[~2025-09-16 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 10:43 [PATCH v2 0/2] Add AMD MDB Endpoint and non-LL mode Support Devendra K Verma
2025-09-16 10:43 ` [PATCH v2 1/2] dmaengine: dw-edma: Add AMD MDB Endpoint Support Devendra K Verma
2025-09-16 10:55 ` [External] : " ALOK TIWARI
2025-09-16 15:05 ` Bjorn Helgaas [this message]
2025-09-17 12:01 ` Verma, Devendra
2025-09-16 15:04 ` Bjorn Helgaas
2025-09-17 11:59 ` Verma, Devendra
2025-09-17 20:08 ` Bjorn Helgaas
2025-09-16 10:43 ` [PATCH v2 2/2] dmaengine: dw-edma: Add non-LL mode Devendra K Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916150532.GA1797586@bhelgaas \
--to=helgaas@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=bhelgaas@google.com \
--cc=devendra.verma@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=michal.simek@amd.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox