Re: [PATCH v2] PCI: rcar-gen4: Add missing 1ms delay after PWR reset assertion

["Krzysztof Wilczyński" <kwilczynski@kernel.org>]

Hello,

[...]
> Because it is the controller driver which can determine whether or not the
> controller is in HSC domain based on its compatible string, add the missing
> delay into the controller driver.
> 
> This 1ms delay is documented on R-Car V4H and V4M, it is currently unclear
> whether S4 is affected as well. This patch does apply the extra delay on
> R-Car S4 as well.

[...]
> -	if (!reset_control_status(dw->core_rsts[DW_PCIE_PWR_RST].rstc))
> +	if (!reset_control_status(dw->core_rsts[DW_PCIE_PWR_RST].rstc)) {
>  		reset_control_assert(dw->core_rsts[DW_PCIE_PWR_RST].rstc);
> +		fsleep(1000);
> +	}

Would it be a prudent thing to do here to add a comment over the fsleep()
or over the if-statement to document briefly (and for posterity) why we
sleep here?

Otherwise, looks good! Thank you for fixing this potential issue.

Reviewed-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Thank you,

	Krzysztof