Re: [Bug 220658] New: [BISECTED] PCI MSI patch causes boot crash on HP Spectre x360 Convertible 14-ea0xxx

Re: [Bug 220658] New: [BISECTED] PCI MSI patch causes boot crash on HP Spectre x360 Convertible 14-ea0xxx

[Bjorn Helgaas]

[+to linux-pci, just breadcrumbs to connect more dots,
+cc Inochi,
+bcc Hervé D., feel free to respond if you'd like your email in
Reported-by and Tested-by for the fix at https://patch.msgid.link/20251014014607.612586-1-inochiama@gmail.com]

On Mon, Oct 13, 2025 at 08:18:18PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=220658
> 
>            Summary: [BISECTED] PCI MSI patch causes boot crash on HP
>                     Spectre x360 Convertible 14-ea0xxx
>     Kernel Version: 6.18.0-rc1
>           Reporter: todd.e.brandt@intel.com
>             Blocks: 178231
>         Regression: Yes
>            Bisected 54f45a30c0d0153d2be091ba2d683ab6db6d1d5b
> 
> Created attachment 308797
>   --> https://bugzilla.kernel.org/attachment.cgi?id=308797&action=edit
> hp_spectre_boot_crash_dmesg.jpg
> 
> As of 6.18.0-rc1 the HP Spectre crashes on boot and throws an exception after
> about 30 seconds. I've attached a jpg of the crash on the screen. I bisected
> the issue first to this merge commit:
> 
> ------------------------------------------------------
> commit 03a53e09cd723295ac1ddd16d9908d1680e7a1bf
> Merge: 3b2074c77d25 c33c43f71bda
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Tue Sep 30 16:00:29 2025 -0700
> 
>     Merge tag 'irq-drivers-2025-09-29' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> 
>     Pull irq chip driver updates from Thomas Gleixner:
> ------------------------------------------------------
> 
> The first bad commit is within this merge applied to 6.17.0-rc1. I can't remove
> it clean but if I build on the commit just prior the failure goes away. So that
> offending commit is:
> 
> ------------------------------------------------------
> commit 54f45a30c0d0153d2be091ba2d683ab6db6d1d5b
> Author: Inochi Amaoto <inochiama@gmail.com>
> Date:   Thu Aug 14 07:28:32 2025 +0800
> 
>     PCI/MSI: Add startup/shutdown for per device domains
> 
>     As the RISC-V PLIC cannot apply affinity settings without invoking
>     irq_enable(), it will make the interrupt unavailble when used as an
>     underlying interrupt chip for the MSI controller.
> 
>     Implement the irq_startup() and irq_shutdown() callbacks for the PCI MSI
>     and MSI-X templates.
> 
>     For chips that specify MSI_FLAG_PCI_MSI_STARTUP_PARENT, the parent startup
>     and shutdown functions are invoked. That allows the interrupt on the parent
>     chip to be enabled if the interrupt has not been enabled during
>     allocation. This is necessary for MSI controllers which use PLIC as
>     underlying parent interrupt chip.
> 
>     Suggested-by: Thomas Gleixner <tglx@linutronix.de>
>     Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>     Tested-by: Chen Wang <unicorn_wang@outlook.com> # Pioneerbox
>     Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
>     Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>     Link:
> https://lore.kernel.org/all/20250813232835.43458-3-inochiama@gmail.com
> 
> 
> Referenced Bugs:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=178231
> [Bug 178231] Meta-bug: Linux suspend-to-mem and freeze performance optimization
> -- 
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

RE: [Bug 220658] New: [BISECTED] PCI MSI patch causes boot crash on HP Spectre x360 Convertible 14-ea0xxx

[Brandt, Todd E]

I tested the linked patch and it appears to boot, the system is fine. Thanks! I'll update the Bugzilla with the fix patch.

Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com>
    Tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>

-----Original Message-----
From: Bjorn Helgaas <helgaas@kernel.org> 
Sent: Thursday, October 16, 2025 9:46 AM
To: linux-pci@vger.kernel.org
Cc: bjorn@helgaas.com; Brandt, Todd E <todd.e.brandt@intel.com>; Inochi Amaoto <inochiama@gmail.com>
Subject: Re: [Bug 220658] New: [BISECTED] PCI MSI patch causes boot crash on HP Spectre x360 Convertible 14-ea0xxx

[+to linux-pci, just breadcrumbs to connect more dots,
+cc Inochi,
+bcc Hervé D., feel free to respond if you'd like your email in
Reported-by and Tested-by for the fix at https://patch.msgid.link/20251014014607.612586-1-inochiama@gmail.com]

On Mon, Oct 13, 2025 at 08:18:18PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=220658
> 
>            Summary: [BISECTED] PCI MSI patch causes boot crash on HP
>                     Spectre x360 Convertible 14-ea0xxx
>     Kernel Version: 6.18.0-rc1
>           Reporter: todd.e.brandt@intel.com
>             Blocks: 178231
>         Regression: Yes
>            Bisected 54f45a30c0d0153d2be091ba2d683ab6db6d1d5b
> 
> Created attachment 308797
>   --> https://bugzilla.kernel.org/attachment.cgi?id=308797&action=edit
> hp_spectre_boot_crash_dmesg.jpg
> 
> As of 6.18.0-rc1 the HP Spectre crashes on boot and throws an 
> exception after about 30 seconds. I've attached a jpg of the crash on 
> the screen. I bisected the issue first to this merge commit:
> 
> ------------------------------------------------------
> commit 03a53e09cd723295ac1ddd16d9908d1680e7a1bf
> Merge: 3b2074c77d25 c33c43f71bda
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Tue Sep 30 16:00:29 2025 -0700
> 
>     Merge tag 'irq-drivers-2025-09-29' of 
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> 
>     Pull irq chip driver updates from Thomas Gleixner:
> ------------------------------------------------------
> 
> The first bad commit is within this merge applied to 6.17.0-rc1. I 
> can't remove it clean but if I build on the commit just prior the 
> failure goes away. So that offending commit is:
> 
> ------------------------------------------------------
> commit 54f45a30c0d0153d2be091ba2d683ab6db6d1d5b
> Author: Inochi Amaoto <inochiama@gmail.com>
> Date:   Thu Aug 14 07:28:32 2025 +0800
> 
>     PCI/MSI: Add startup/shutdown for per device domains
> 
>     As the RISC-V PLIC cannot apply affinity settings without invoking
>     irq_enable(), it will make the interrupt unavailble when used as an
>     underlying interrupt chip for the MSI controller.
> 
>     Implement the irq_startup() and irq_shutdown() callbacks for the PCI MSI
>     and MSI-X templates.
> 
>     For chips that specify MSI_FLAG_PCI_MSI_STARTUP_PARENT, the parent startup
>     and shutdown functions are invoked. That allows the interrupt on the parent
>     chip to be enabled if the interrupt has not been enabled during
>     allocation. This is necessary for MSI controllers which use PLIC as
>     underlying parent interrupt chip.
> 
>     Suggested-by: Thomas Gleixner <tglx@linutronix.de>
>     Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>     Tested-by: Chen Wang <unicorn_wang@outlook.com> # Pioneerbox
>     Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
>     Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>     Link:
> https://lore.kernel.org/all/20250813232835.43458-3-inochiama@gmail.com
> 
> 
> Referenced Bugs:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=178231
> [Bug 178231] Meta-bug: Linux suspend-to-mem and freeze performance 
> optimization
> --
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

Re: [Bug 220658] New: [BISECTED] PCI MSI patch causes boot crash on HP Spectre x360 Convertible 14-ea0xxx

[Bjorn Helgaas]

On Thu, Oct 16, 2025 at 06:58:55PM +0000, Brandt, Todd E wrote:
> I tested the linked patch and it appears to boot, the system is fine. Thanks! I'll update the Bugzilla with the fix patch.
> 
> Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com>
>     Tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>

Thanks, Todd!  Already had your Reported-by, also added your
Tested-by.