From: Bjorn Helgaas <helgaas@kernel.org>
To: Matthew W Carlis <mattc@purestorage.com>
Cc: ahuang12@lenovo.com, alok.a.tiwari@oracle.com,
ashishk@purestorage.com, bhelgaas@google.com,
guojinhui.liam@bytedance.com, ilpo.jarvinen@linux.intel.com,
jiwei.sun.bj@qq.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, lukas@wunner.de, macro@orcam.me.uk,
msaggi@purestorage.com, sconnor@purestorage.com,
sunjw10@lenovo.com
Subject: Re: [PATCH] PCI: Always lift 2.5GT/s restriction in PCIe failed link retraining
Date: Thu, 19 Feb 2026 16:53:22 -0600 [thread overview]
Message-ID: <20260219225322.GA3501275@bhelgaas> (raw)
In-Reply-To: <20260219220959.19900-1-mattc@purestorage.com>
On Thu, Feb 19, 2026 at 03:09:59PM -0700, Matthew W Carlis wrote:
> On Thu, 19 Feb 2026, Bjorn Helgaas wrote:
>
> > Applied to pci/enumeration for v7.1, thanks. This will be rebased
> > after v7.0-rc1.
>
> We're heading down a path here where we keep working around the
> work-around & now have decided that the kernel will be meddling with
> the link on potentially all of the PCIe devices in the world. The
> trade off that we're making here to accommodate a device specific
> interaction doesn't seem like the right direction.
>
> Can we reconsider my patch that restricts the link retrain mechanism
> to the specific device that created the work-around?
> https://lore.kernel.org/all/20250702052430.13716-1-mattc@purestorage.com/
I think we already at least potentially meddle with the link on every
device, and it definitely makes me nervous. I would like it much
better if it's possible to limit it to devices with known defects.
I'll defer these for now and we can see if a consensus emerges.
next prev parent reply other threads:[~2026-02-19 22:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 19:24 [PATCH v2 0/3] PCI: Always lift 2.5GT/s restriction in PCIe failed link retraining Maciej W. Rozycki
2025-12-08 19:24 ` [PATCH v2 1/3] " Maciej W. Rozycki
2026-02-05 11:00 ` [External] : " ALOK TIWARI
2025-12-08 19:24 ` [PATCH v2 2/3] PCI: Use pcie_get_speed_cap() " Maciej W. Rozycki
2026-02-05 10:59 ` [External] : " ALOK TIWARI
2025-12-08 19:24 ` [PATCH v2 3/3] PCI: Bail out early for 2.5GT/s devices " Maciej W. Rozycki
2026-02-05 10:57 ` [External] : " ALOK TIWARI
2026-02-04 17:12 ` [PING][PATCH v2 0/3] PCI: Always lift 2.5GT/s restriction " Maciej W. Rozycki
2026-02-19 3:42 ` ALOK TIWARI
2026-03-09 15:45 ` ALOK TIWARI
2026-02-19 21:26 ` [PATCH " Bjorn Helgaas
2026-02-19 22:09 ` [PATCH] " Matthew W Carlis
2026-02-19 22:53 ` Bjorn Helgaas [this message]
2026-02-20 12:03 ` Maciej W. Rozycki
2026-02-23 17:36 ` Bjorn Helgaas
2026-02-23 22:49 ` Matthew W Carlis
2026-02-23 23:14 ` Maciej W. Rozycki
2026-02-25 1:41 ` Matthew W Carlis
2026-02-26 22:02 ` Maciej W. Rozycki
2026-03-26 19:52 ` ALOK TIWARI
-- strict thread matches above, loose matches on Subject: below --
2025-12-01 3:52 Maciej W. Rozycki
2025-12-01 9:45 ` Ilpo Järvinen
2025-12-01 13:55 ` Maciej W. Rozycki
2025-12-01 16:48 ` Ilpo Järvinen
2025-12-08 19:24 ` Maciej W. Rozycki
2025-12-04 18:30 ` Matthew W Carlis
2025-12-08 19:25 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219225322.GA3501275@bhelgaas \
--to=helgaas@kernel.org \
--cc=ahuang12@lenovo.com \
--cc=alok.a.tiwari@oracle.com \
--cc=ashishk@purestorage.com \
--cc=bhelgaas@google.com \
--cc=guojinhui.liam@bytedance.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiwei.sun.bj@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=mattc@purestorage.com \
--cc=msaggi@purestorage.com \
--cc=sconnor@purestorage.com \
--cc=sunjw10@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox