From: Matthew W Carlis <mattc@purestorage.com>
To: macro@orcam.me.uk
Cc: ahuang12@lenovo.com, alok.a.tiwari@oracle.com,
ashishk@purestorage.com, bamstadt@purestorage.com,
bhelgaas@google.com, guojinhui.liam@bytedance.com,
ilpo.jarvinen@linux.intel.com, jiwei.sun.bj@qq.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lukas@wunner.de, mattc@purestorage.com, msaggi@purestorage.com,
sconnor@purestorage.com, sunjw10@lenovo.com
Subject: Re: [PATCH] PCI: Always lift 2.5GT/s restriction in PCIe failed link retraining
Date: Thu, 4 Dec 2025 11:30:36 -0700 [thread overview]
Message-ID: <20251204183036.39649-1-mattc@purestorage.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2511290245460.36486@angie.orcam.me.uk>
I'm sorry my last response kind of messed up the threading in this chain...
I don't understand why we still think its a good idea to have this action
in the kernel for any device type since it seems to only help Maciej W. Rozycki's
specific situation which is very likely to be the only one of its kind. In
addition the Delock adapter isn't what I would consider a particularly
"solid" device.
For what its worth I have a particular Gen5 device in my lab here that gets stuck
in an infinite link up-down loop when you force the speed to Gen2 when also combined
with a specific downstream port... I'm sure there is another device somewhere else
in the world that has the same issue when you force it to Gen1.
The kernel should assume a PCIe link will automatically train to the best
speed that the devices can achieve & if the link fails to train then it should
be up to the user space to decide what to do with it in my opinion.
next prev parent reply other threads:[~2025-12-04 18:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 3:52 [PATCH] PCI: Always lift 2.5GT/s restriction in PCIe failed link retraining Maciej W. Rozycki
2025-12-01 9:45 ` Ilpo Järvinen
2025-12-01 13:55 ` Maciej W. Rozycki
2025-12-01 16:48 ` Ilpo Järvinen
2025-12-08 19:24 ` Maciej W. Rozycki
2025-12-02 13:49 ` [External] : " ALOK TIWARI
2025-12-02 16:07 ` Ilpo Järvinen
2025-12-03 19:01 ` Maciej W. Rozycki
2025-12-08 19:25 ` Maciej W. Rozycki
2025-12-04 1:40 ` [PATCH 2/2] PCI: Fix the PCIe bridge decreasing to Gen 1 during hotplug testing Matthew W Carlis
2025-12-04 23:43 ` Maciej W. Rozycki
2025-12-04 18:30 ` Matthew W Carlis [this message]
2025-12-08 19:25 ` [PATCH] PCI: Always lift 2.5GT/s restriction in PCIe failed link retraining Maciej W. Rozycki
-- strict thread matches above, loose matches on Subject: below --
2026-02-19 21:26 [PATCH v2 0/3] " Bjorn Helgaas
2026-02-19 22:09 ` [PATCH] " Matthew W Carlis
2026-02-19 22:53 ` Bjorn Helgaas
2026-02-20 12:03 ` Maciej W. Rozycki
2026-02-23 17:36 ` Bjorn Helgaas
2026-02-23 22:49 ` Matthew W Carlis
2026-02-23 23:14 ` Maciej W. Rozycki
2026-02-25 1:41 ` Matthew W Carlis
2026-02-26 22:02 ` Maciej W. Rozycki
2026-03-26 19:52 ` ALOK TIWARI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204183036.39649-1-mattc@purestorage.com \
--to=mattc@purestorage.com \
--cc=ahuang12@lenovo.com \
--cc=alok.a.tiwari@oracle.com \
--cc=ashishk@purestorage.com \
--cc=bamstadt@purestorage.com \
--cc=bhelgaas@google.com \
--cc=guojinhui.liam@bytedance.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiwei.sun.bj@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=msaggi@purestorage.com \
--cc=sconnor@purestorage.com \
--cc=sunjw10@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox