Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-pci@vger.kernel.org, herve.codina@bootlin.com,
	bhelgaas@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: of: Reduce severity of missing of_root error message
Date: Mon, 9 Mar 2026 16:17:04 -0500	[thread overview]
Message-ID: <20260309211704.GA605986@bhelgaas> (raw)
In-Reply-To: <20260309045930.21531-1-jeremy.linton@arm.com>

On Sun, Mar 08, 2026 at 11:59:30PM -0500, Jeremy Linton wrote:
> Arm64 kernels are frequently built dual ACPI/DT, and then boot in ACPI
> mode. In this case, there won't be an of_root, except for rare DT
> described PCIe boards.
> 
> As a result, users in the common case see this high priority worrying
> message, despite the machine working as expected.
> 
> Reduce this message to pr_debug() to avoid unnecessary noise.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Applied to pci/misc for v7.1, thanks!

> ---
>  drivers/pci/of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 3579265f1198..4115017f4139 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
>  
>  	/* Check if there is a DT root node to attach the created node */
>  	if (!of_root) {
> -		pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
> +		pr_debug("of_root node is NULL, cannot create PCI host bridge node\n");
>  		return;
>  	}
>  
> -- 
> 2.53.0
> 

      reply	other threads:[~2026-03-09 21:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  4:59 [PATCH] PCI: of: Reduce severity of missing of_root error message Jeremy Linton
2026-03-09 21:17 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309211704.GA605986@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=herve.codina@bootlin.com \
    --cc=jeremy.linton@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox