* [PATCH] PCI: of: Reduce severity of missing of_root error message
@ 2026-03-09 4:59 Jeremy Linton
2026-03-09 21:17 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Linton @ 2026-03-09 4:59 UTC (permalink / raw)
To: linux-pci; +Cc: herve.codina, bhelgaas, linux-kernel, Jeremy Linton
Arm64 kernels are frequently built dual ACPI/DT, and then boot in ACPI
mode. In this case, there won't be an of_root, except for rare DT
described PCIe boards.
As a result, users in the common case see this high priority worrying
message, despite the machine working as expected.
Reduce this message to pr_debug() to avoid unnecessary noise.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
drivers/pci/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..4115017f4139 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
/* Check if there is a DT root node to attach the created node */
if (!of_root) {
- pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+ pr_debug("of_root node is NULL, cannot create PCI host bridge node\n");
return;
}
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: of: Reduce severity of missing of_root error message
2026-03-09 4:59 [PATCH] PCI: of: Reduce severity of missing of_root error message Jeremy Linton
@ 2026-03-09 21:17 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2026-03-09 21:17 UTC (permalink / raw)
To: Jeremy Linton; +Cc: linux-pci, herve.codina, bhelgaas, linux-kernel
On Sun, Mar 08, 2026 at 11:59:30PM -0500, Jeremy Linton wrote:
> Arm64 kernels are frequently built dual ACPI/DT, and then boot in ACPI
> mode. In this case, there won't be an of_root, except for rare DT
> described PCIe boards.
>
> As a result, users in the common case see this high priority worrying
> message, despite the machine working as expected.
>
> Reduce this message to pr_debug() to avoid unnecessary noise.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Applied to pci/misc for v7.1, thanks!
> ---
> drivers/pci/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 3579265f1198..4115017f4139 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
>
> /* Check if there is a DT root node to attach the created node */
> if (!of_root) {
> - pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
> + pr_debug("of_root node is NULL, cannot create PCI host bridge node\n");
> return;
> }
>
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-09 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 4:59 [PATCH] PCI: of: Reduce severity of missing of_root error message Jeremy Linton
2026-03-09 21:17 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox