Re: [PATCH v8 phy-next 11/31] scsi: ufs: qcom: call phy_init() before phy_power_on()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a compilation error by removing a label but leaving a `goto` statement referencing it.
--

commit a9b6eda8b500b1bd6c9826051626a38b21091a29
Author: Vladimir Oltean <vladimir.oltean@nxp.com>

scsi: ufs: qcom: call phy_init() before phy_power_on()

This commit changes the order of PHY API calls in the Qualcomm UFS driver to
comply with the Generic PHY API expectations. It moves phy_init() to
ufs_qcom_init() and removes the vestigial initialization from
ufs_qcom_power_up_sequence().

> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index bc037db46624a..9039b087bf214 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
[ ... ]
> @@ -513,13 +513,6 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
>  
>  
>  	/* phy initialization - calibrate the phy */
> -	ret = phy_init(phy);
> -	if (ret) {
> -		dev_err(hba->dev, "%s: phy init failed, ret = %d\n",
> -			__func__, ret);
> -		return ret;
> -	}
> -
>  	ret = phy_set_mode_ext(phy, mode, host->phy_gear);
>  	if (ret)
>  		goto out_disable_phy;

Does this cause a compilation error? The goto statement jumps to the
out_disable_phy label, but the label is removed by this patch at the end of
the function.

[ ... ]
> @@ -529,23 +522,18 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
[ ... ]
>  	ufs_qcom_select_unipro_mode(host);
>  
>  	return 0;
> -
> -out_disable_phy:
> -	phy_exit(phy);
> -
> -	return ret;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260505100523.1922388-1-vladimir.oltean@nxp.com?part=11