Re: [PATCH v8 phy-next 21/31] drm/rockchip: dsi: include PHY provider header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch includes a private header from another subsystem using a relative path (`../../../phy/phy-provider.h`), breaking subsystem isolation boundaries.
--

commit 82e5f2c2c18bd726ffe8bde8959c86cab426ad1e
Author: Vladimir Oltean <vladimir.oltean@nxp.com>

drm/rockchip: dsi: include PHY provider header

This commit updates the Rockchip DSI controller driver to include the PHY
provider header using a relative path. The driver acts as both a PHY consumer
and provider, which requires access to the provider APIs.

> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> index 3547d91b25d31..c0aaa51e02375 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> @@ -27,6 +27,7 @@
>  #include <drm/drm_print.h>
>  #include <drm/drm_simple_kms_helper.h>
>  
> +#include "../../../phy/phy-provider.h" /* FIXME */

This isn't a bug, but does including a private header from another subsystem
using a deep relative path create brittle coupling across the source tree?

While the commit message notes this is discouraged but difficult to address
without moving the driver, bypassing the generic PHY framework's isolation
boundaries this way could cause compilation issues if the phy directory
structure changes in the future.

>  #include "rockchip_drm_drv.h"
>  
>  #define DSI_PHY_RSTZ			0xa0

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260505100523.1922388-1-vladimir.oltean@nxp.com?part=21