Re: [PATCH v4 08/16] vfio: selftests: Build liveupdate library in VFIO selftests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The VFIO selftest Makefile includes `../liveupdate/lib/libliveupdate.mk`, which does not exist, causing a build failure and leaving `LIBLIVEUPDATE_O` undefined.
--

commit d3eae23e3b6d5e95208bbaa8caae8ddebad58cb5
Author: Vipin Sharma <vipinsh@google.com>

vfio: selftests: Build liveupdate library in VFIO selftests

Import and build the liveupdate selftest library in VFIO selftests to allow
using liveupdate ioctls.

> diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> index 0684932d91bfc..7865b2aa011c3 100644
> --- a/tools/testing/selftests/vfio/Makefile
> +++ b/tools/testing/selftests/vfio/Makefile
> @@ -20,6 +20,7 @@ TEST_FILES += scripts/setup.sh
>  
>  include ../lib.mk
>  include lib/libvfio.mk
> +include ../liveupdate/lib/libliveupdate.mk

Is it possible this file is missing from the tree?

Neither the lib directory nor the libliveupdate.mk file appear to exist under
tools/testing/selftests/liveupdate/. This will cause a build failure since
make requires the included file to be present.

>  
>  CFLAGS += -I$(top_srcdir)/tools/include
>  CFLAGS += -MD
> @@ -27,11 +28,15 @@ CFLAGS += $(EXTRA_CFLAGS)
>  
>  LDFLAGS += -pthread
>  
> -$(TEST_GEN_PROGS): %: %.o $(LIBVFIO_O)
> -	$(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $< $(LIBVFIO_O) $(LDLIBS) -o $@
> +LIBS_O := $(LIBVFIO_O)
> +LIBS_O += $(LIBLIVEUPDATE_O)

Since the libliveupdate.mk inclusion fails, LIBLIVEUPDATE_O remains undefined
here. Does this also cause missing object files during linking?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511234802.2280368-1-vipinsh@google.com?part=8