Re: [PATCH v4 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Including the private header of the `pci-host-common` framework into the DesignWare Core (DWC) framework introduces an inappropriate cross-driver dependency.
--

commit 826f6ff69b866addd978e8c94219d9a3f4ffea60
Author: Hans Zhang <18255117159@163.com>

PCI: dwc: Use common pci_host_common_link_train_delay() helper

This commit replaces an open-coded 100ms link training delay in the
DesignWare Core (DWC) driver with the pci_host_common_link_train_delay()
helper. It adds a relative path include to access the helper from the
generic host framework.

> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index c11cf61b8319e..7021d21bb6011 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -22,6 +22,7 @@
>  #include <linux/sizes.h>
>  #include <linux/types.h>
>  
> +#include "../pci-host-common.h"
>  #include "../../pci.h"
>  #include "pcie-designware.h"

This isn't a bug, but does including a sibling framework's private header
using a relative path violate component isolation?

Since pci-host-common.h is specific to the generic ECAM host controller
architecture, and DWC is a completely separate controller architecture,
reusing this helper directly introduces a cross-driver dependency.

Because the 100 ms link training delay is a generic PCIe specification
requirement (PCIe r6.0 sec 6.6.1), should this helper be relocated to a
shared PCI core header such as drivers/pci/pci.h instead of remaining in
the pci-host-common framework?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518004246.1384532-1-18255117159@163.com?part=4