From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pranjal Shrivastava <praan@google.com>
Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Mostafa Saleh <smostafa@google.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Samiullah Khawaja <skhawaja@google.com>,
Daniel Mentz <danielmentz@google.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
David Matlack <dmatlack@google.com>
Subject: Re: [PATCH v3 3/3] iommu/arm-smmu-v3: Fix ATS state tracking via ats_prepared gate
Date: Tue, 19 May 2026 11:44:30 -0300 [thread overview]
Message-ID: <20260519144430.GI7702@ziepe.ca> (raw)
In-Reply-To: <20260519135323.1558777-4-praan@google.com>
On Tue, May 19, 2026 at 01:53:22PM +0000, Pranjal Shrivastava wrote:
> @@ -4450,7 +4450,8 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev)
> if (dev_is_pci(dev)) {
> unsigned int stu = __ffs(smmu->pgsize_bitmap);
>
> - pci_prepare_ats(to_pci_dev(dev), stu);
> + if (!pci_prepare_ats(to_pci_dev(dev), stu))
> + master->ats_prepared = true;
> }
This should fail not keep going, it is a kernel bug if
pci_prepare_ats() fails.
Jason
next prev parent reply other threads:[~2026-05-19 14:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 13:53 [PATCH v3 0/3] iommu/arm-smmu-v3: Fix ATS robustness and state tracking Pranjal Shrivastava
2026-05-19 13:53 ` [PATCH v3 1/3] PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs Pranjal Shrivastava
2026-05-19 14:41 ` Jason Gunthorpe
2026-05-19 19:02 ` Samiullah Khawaja
2026-05-19 13:53 ` [PATCH v3 2/3] PCI/ATS: Validate STU for VFs in pci_prepare_ats() Pranjal Shrivastava
2026-05-19 14:43 ` Jason Gunthorpe
2026-05-19 19:05 ` Samiullah Khawaja
2026-05-19 13:53 ` [PATCH v3 3/3] iommu/arm-smmu-v3: Fix ATS state tracking via ats_prepared gate Pranjal Shrivastava
2026-05-19 14:44 ` Jason Gunthorpe [this message]
2026-05-19 14:55 ` Pranjal Shrivastava
2026-05-19 14:59 ` Jason Gunthorpe
2026-05-19 20:01 ` Samiullah Khawaja
2026-05-20 14:29 ` Pranjal Shrivastava
2026-05-20 14:24 ` Pranjal Shrivastava
2026-05-20 14:51 ` Jason Gunthorpe
2026-05-20 16:24 ` Pranjal Shrivastava
2026-05-20 16:31 ` Jason Gunthorpe
2026-05-22 16:14 ` Pranjal Shrivastava
2026-05-23 12:34 ` Jason Gunthorpe
2026-05-25 18:38 ` Pranjal Shrivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519144430.GI7702@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bhelgaas@google.com \
--cc=danielmentz@google.com \
--cc=dmatlack@google.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-pci@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox