From: Samiullah Khawaja <skhawaja@google.com>
To: Pranjal Shrivastava <praan@google.com>
Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Mostafa Saleh <smostafa@google.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Daniel Mentz <danielmentz@google.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
David Matlack <dmatlack@google.com>
Subject: Re: [PATCH v3 1/3] PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs
Date: Tue, 19 May 2026 19:02:06 +0000 [thread overview]
Message-ID: <agyzpVjLtxgr-BFt@google.com> (raw)
In-Reply-To: <20260519135323.1558777-2-praan@google.com>
On Tue, May 19, 2026 at 01:53:20PM +0000, Pranjal Shrivastava wrote:
>Update pci_ats_supported() to additionally check the associated PF's
>status when called on a VF. This ensures that PF-level quirks and
>untrusted status are correctly propagated to VFs, providing a robust
>support check that aligns with the kernel's PF-centric ATS configuration
>model and is immune to the timing of VF-specific fixups.
>
>Signed-off-by: Pranjal Shrivastava <praan@google.com>
>---
> drivers/pci/ats.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
>index ec6c8dbdc5e9..a5fa7745bce8 100644
>--- a/drivers/pci/ats.c
>+++ b/drivers/pci/ats.c
>@@ -40,10 +40,13 @@ void pci_ats_init(struct pci_dev *dev)
> */
> bool pci_ats_supported(struct pci_dev *dev)
> {
>- if (!dev->ats_cap)
>+ if (!dev->ats_cap || dev->untrusted)
> return false;
>
>- return (dev->untrusted == 0);
>+ if (dev->is_virtfn)
>+ return pci_ats_supported(pci_physfn(dev));
>+
>+ return true;
> }
> EXPORT_SYMBOL_GPL(pci_ats_supported);
>
>--
>2.54.0.563.g4f69b47b94-goog
>
Reviewed-by: Samiullah Khawaja <skhawaja@google.com>
next prev parent reply other threads:[~2026-05-19 19:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 13:53 [PATCH v3 0/3] iommu/arm-smmu-v3: Fix ATS robustness and state tracking Pranjal Shrivastava
2026-05-19 13:53 ` [PATCH v3 1/3] PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs Pranjal Shrivastava
2026-05-19 14:41 ` Jason Gunthorpe
2026-05-19 19:02 ` Samiullah Khawaja [this message]
2026-05-19 13:53 ` [PATCH v3 2/3] PCI/ATS: Validate STU for VFs in pci_prepare_ats() Pranjal Shrivastava
2026-05-19 14:43 ` Jason Gunthorpe
2026-05-19 19:05 ` Samiullah Khawaja
2026-05-19 13:53 ` [PATCH v3 3/3] iommu/arm-smmu-v3: Fix ATS state tracking via ats_prepared gate Pranjal Shrivastava
2026-05-19 14:44 ` Jason Gunthorpe
2026-05-19 14:55 ` Pranjal Shrivastava
2026-05-19 14:59 ` Jason Gunthorpe
2026-05-19 20:01 ` Samiullah Khawaja
2026-05-20 14:29 ` Pranjal Shrivastava
2026-05-20 14:24 ` Pranjal Shrivastava
2026-05-20 14:51 ` Jason Gunthorpe
2026-05-20 16:24 ` Pranjal Shrivastava
2026-05-20 16:31 ` Jason Gunthorpe
2026-05-22 16:14 ` Pranjal Shrivastava
2026-05-23 12:34 ` Jason Gunthorpe
2026-05-25 18:38 ` Pranjal Shrivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agyzpVjLtxgr-BFt@google.com \
--to=skhawaja@google.com \
--cc=bhelgaas@google.com \
--cc=danielmentz@google.com \
--cc=dmatlack@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-pci@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox