Re: [PATCH v12 2/6] PCI/TPH: Export pcie_tph_get_st_modes() for external use

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The header `<linux/pci-tph.h>` is not self-contained due to newly introduced dependencies without corresponding `#include` directives.
--

commit 1f564e5018d91508967ee58123260567c2507196
Author: Chengwen Feng <fengchengwen@huawei.com>

PCI/TPH: Export pcie_tph_get_st_modes() for external use

This commit exports pcie_tph_get_st_modes() to allow drivers like VFIO
to query PCIe TPH capabilities. It also adds stub functions for
!CONFIG_PCIE_TPH and tph_cap validation to prevent invalid configuration
space accesses.

> diff --git a/include/linux/pci-tph.h b/include/linux/pci-tph.h
> --- a/include/linux/pci-tph.h
> +++ b/include/linux/pci-tph.h

[ ... ]

> @@ -41,6 +42,12 @@ static inline int pcie_tph_get_cpu_st(struct pci_dev *dev,
>  static inline void pcie_disable_tph(struct pci_dev *pdev) { }
>  static inline int pcie_enable_tph(struct pci_dev *pdev, int mode)
>  { return -EINVAL; }
> +static inline u16 pcie_tph_get_st_table_size(struct pci_dev *pdev)
> +{ return 0; }
> +static inline u32 pcie_tph_get_st_table_loc(struct pci_dev *pdev)
> +{ return PCI_TPH_LOC_NONE; }

[Severity: Low]
Does this new stub make linux/pci-tph.h rely on implicit includes?

PCI_TPH_LOC_NONE is defined in uapi/linux/pci_regs.h, but it doesn't look
like linux/pci-tph.h includes it (or linux/pci.h). While current users
probably already include linux/pci.h, could this cause compilation errors if
a driver includes linux/pci-tph.h first or on its own?

> +static inline u8 pcie_tph_get_st_modes(struct pci_dev *pdev)
> +{ return 0; }
>  #endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526040830.52854-1-fengchengwen@huawei.com?part=2