Re: [PATCH v2 09/21] lib: rspdm: Initial commit of Rust SPDM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Kconfig symbol `RSPDM` selects `X509_CERTIFICATE_PARSER` but does not inherit its required dependencies, causing an unmet direct dependencies warning.
--

commit e58dc22b70e82677b92465a9ddd6e228870b413f
Author: Alistair Francis <alistair@alistair23.me>

lib: rspdm: Initial commit of Rust SPDM

This commit introduces the initial implementation of the Rust SPDM library.

> diff --git a/lib/Kconfig b/lib/Kconfig
> index 55748b68714e0..aad8439534bfe 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
[ ... ]
> @@ -594,6 +594,20 @@ config LWQ_TEST
>  	help
>  	  Run boot-time test of light-weight queuing.
>  
> +config RSPDM
> +	bool "Rust SPDM"
> +	depends on RUST
> +	select CRYPTO
> +	select X509_CERTIFICATE_PARSER

[Severity: Low]
Does this selection need to inherit the dependencies of
X509_CERTIFICATE_PARSER?

Selecting a symbol without inheriting its required dependencies can cause an
unmet direct dependencies warning. For example, if a user configures the
kernel with CONFIG_RSPDM=y on a configuration where
CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE is not enabled, it could lead to build
warnings or failures.

> +	help
> +	  The Rust implementation of the Security Protocol and Data Model (SPDM)
> +	  allows for device authentication, measurement, key exchange and
> +	  encrypted sessions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623045406.2589547-1-alistair.francis@wdc.com?part=9